carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 22:02:23 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Change CodeGen::Make() to take module and errors as pointers and not references (#5229)

Browse Source 
Per [the style
guide](https://github.com/carbon-language/carbon-lang/blob/trunk/docs/project/cpp_style_guide.md#syntax-and-formatting):
* If it is captured and must outlive the call expression itself, use a
pointer and document that it must not be null (unless it is also
optional).
* When storing an object's address as a non-owned member, prefer storing
a pointer.
This commit is contained in:
Boaz Brickner
2025-04-01 14:55:04 +00:00
committed by GitHub
parent 6e2dbb5b61
commit ccd2cb346a
3 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/codegen/codegen.h
+7 -5
View File
@@ -12,8 +12,9 @@ namespace Carbon {
class CodeGen {
public:
static auto Make(llvm::Module& module, llvm::StringRef target_triple,
llvm::raw_pwrite_stream& errors) -> std::optional<CodeGen>;
// `module` and `errors` must not be null.
static auto Make(llvm::Module* module, llvm::StringRef target_triple,
llvm::raw_pwrite_stream* errors) -> std::optional<CodeGen>;
// Generates the object code file.
// Returns false in case of failure, and any information about the failure is
@@ -32,7 +33,8 @@ class CodeGen {
auto EmitAssembly(llvm::raw_pwrite_stream& out) -> bool;
private:
explicit CodeGen(llvm::Module& module, llvm::raw_pwrite_stream& errors)
// `module` and `errors` must not be null.
explicit CodeGen(llvm::Module* module, llvm::raw_pwrite_stream* errors)
: module_(module), errors_(errors) {}
// Using the llvm pass emits either assembly or object code to dest.
@@ -41,8 +43,8 @@ class CodeGen {
auto EmitCode(llvm::raw_pwrite_stream& out, llvm::CodeGenFileType file_type)
-> bool;
llvm::Module& module_;
llvm::raw_pwrite_stream& errors_;
llvm::Module* module_;
llvm::raw_pwrite_stream* errors_;
std::unique_ptr<llvm::TargetMachine> target_machine_;
};