From ccd127008aa2aa0a303c9a0a48f4080a5bb7cd0b Mon Sep 17 00:00:00 2001 From: Nathan James Date: Wed, 17 Jun 2020 14:35:32 +0100 Subject: [PATCH] [clang-tidy] warnings-as-error no longer exits with ErrorCount When using `-warnings-as-errors`, If there are any warnings promoted to errors, clang-tidy exits with the number of warnings. This really isn't needed and can cause issues when the number of warnings doesn't fit into 8 bits as POSIX terminals aren't designed to handle more than that. This addresses https://bugs.llvm.org/show_bug.cgi?id=46305. Bug originally added in D15528 Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D81953 --- clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp index aca16b0d6d81..7f668345bbb1 100644 --- a/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp +++ b/clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp @@ -478,7 +478,7 @@ int clangTidyMain(int argc, const char **argv) { llvm::errs() << WErrorCount << " warning" << Plural << " treated as error" << Plural << "\n"; } - return WErrorCount; + return 1; } if (FoundErrors) {