carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove ExpectType and some calls to IsImplicitlyConvertible. (#2647)

Browse Source 
These functions are dangerous, as they check whether conversions are possible without actually performing the conversions. In each case where they were used, explorer would crash in some cases if a user-defined conversion is required.

This change moves us more towards implicit conversions being handled by a regular function call on an interface and away from them being magical builtins. Unfortunately, this exposes a pre-existing bug that a call of the form `x.(ImplicitAs(T).Convert)()` compiles even if `x` only has an explicit conversion to `T`. That's worked around here for now, but will need a proper fix later.
This commit is contained in:
Richard Smith
2023-03-02 14:04:44 -08:00
committed by GitHub
parent 21c3f64564
commit c8141b59d9
16 changed files with 152 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/testdata/pointer/fail_invalid_ptr_conversion2.carbon
Vendored
+1 -1
View File
@@ -13,7 +13,7 @@ class A {}
fn Main() -> i32 {
var a: i32 = 0;
var b: i32* = &a;
// CHECK:STDERR: COMPILATION ERROR: {{.*}}/explorer/testdata/pointer/fail_invalid_ptr_conversion2.carbon:[[@LINE+1]]: type error in name binding: 'i32*' is not implicitly convertible to 'class A*'
// CHECK:STDERR: COMPILATION ERROR: {{.*}}/explorer/testdata/pointer/fail_invalid_ptr_conversion2.carbon:[[@LINE+1]]: type error in initializer of variable: 'i32*' is not implicitly convertible to 'class A*'
var c: A* = b;
return 1;
}