mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Rename template constant -> concrete constant. (#4939)
This implements a direction decided in a [recent discussion](https://docs.google.com/document/d/1Iut5f2TQBrtBNIduF4vJYOKfw7MbS8xH_J01_Q4e6Rk/edit?resourcekey=0-mc_vh5UzrzXfU4kO-3tOjA&tab=t.0#heading=h.mas1g68xx9ct) to switch away from "template constant" when naming a constant that doesn't depend on any generic parameters, because that creates confusion with template-dependent constant values that depend on a template parameter.
This commit is contained in:
@@ -320,8 +320,8 @@ class SubstConstantCallbacks final : public SubstInstCallbacks {
|
||||
// Applies the given Substitutions to an instruction, in order to replace
|
||||
// BindSymbolicName instructions with the value of the binding.
|
||||
auto Subst(SemIR::InstId& inst_id) const -> bool override {
|
||||
if (context_.constant_values().Get(inst_id).is_template()) {
|
||||
// This instruction is a template constant, so can't contain any
|
||||
if (context_.constant_values().Get(inst_id).is_concrete()) {
|
||||
// This instruction is a concrete constant, so can't contain any
|
||||
// bindings that need to be substituted.
|
||||
return true;
|
||||
}
|
||||
@@ -380,7 +380,7 @@ auto SubstConstant(Context& context, SemIR::ConstantId const_id,
|
||||
}
|
||||
|
||||
if (!const_id.is_symbolic()) {
|
||||
// A template constant can't contain a reference to a symbolic binding.
|
||||
// A concrete constant can't contain a reference to a symbolic binding.
|
||||
return const_id;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user