carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 19:41:07 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Replace GetTypeInSpecific with GetTypeOfInstInSpecific. (#5232)

Browse Source 
Reduce usage of `GetConstantInSpecific` to a single caller in constant
evaluation, with a TODO to remove that.

This gets us closer to being able to fully perform type-checking against
abstract types instead of types anchored within a particular generic.
This commit is contained in:
Richard Smith
2025-04-02 22:52:11 +00:00
committed by GitHub
parent 077cf56a8a
commit c33adfafd3
12 changed files with 132 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/file_context.cpp
+4 -6
View File
@@ -215,13 +215,11 @@ auto FileContext::BuildFunctionTypeInfo(const SemIR::Function& function,
/*isVarArg=*/false)};
}
// TODO nit: add is_symbolic() to type_id to forward to
// type_id.AsConstantId().is_symbolic(). Update call below too.
auto get_llvm_type = [&](SemIR::TypeId type_id) -> llvm::Type* {
if (!type_id.has_value()) {
return nullptr;
}
return GetType(SemIR::GetTypeInSpecific(sem_ir(), specific_id, type_id));
return GetType(type_id);
};
// TODO: expose the `Call` parameter patterns in `Function`, and use them here
@@ -267,8 +265,8 @@ auto FileContext::BuildFunctionTypeInfo(const SemIR::Function& function,
if (!param_pattern_info) {
continue;
}
auto param_type_id = SemIR::GetTypeInSpecific(
sem_ir(), specific_id, param_pattern_info->inst.type_id);
auto param_type_id = SemIR::GetTypeOfInstInSpecific(
sem_ir(), specific_id, param_pattern_info->inst_id);
CARBON_CHECK(
!param_type_id.AsConstantId().is_symbolic(),
"Found symbolic type id after resolution when lowering type {0}.",
@@ -412,7 +410,7 @@ auto FileContext::BuildFunctionBody(SemIR::FunctionId function_id,
++param_index;
} else {
param_value = llvm::PoisonValue::get(GetType(
SemIR::GetTypeInSpecific(sem_ir(), specific_id, param_inst.type_id)));
SemIR::GetTypeOfInstInSpecific(sem_ir(), specific_id, param_id)));
}
// The value of the parameter is the value of the argument.
function_lowering.SetLocal(param_id, param_value);