carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Ignore abstract functions when checking for referenced functions requiring definitions (#5816)

Browse Source 
Abstract functions can't be defined, so we shouldn't be checking for
definitions when the function is referenced from an abstract base's
vtable.
This commit is contained in:
David Blaikie
2025-07-17 20:25:59 +00:00
committed by GitHub
parent aeba878335
commit c25ea81320
2 changed files with 43 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/eval_inst.cpp
+6 -6
View File
@@ -485,12 +485,12 @@ auto EvalConstantInst(Context& context, SemIR::InstId inst_id,
auto EvalConstantInst(Context& context, SemIR::InstId inst_id,
SemIR::SpecificFunction inst) -> ConstantEvalResult {
if (auto callee_function =
SemIR::GetCalleeFunction(context.sem_ir(), inst.callee_id);
!callee_function.self_type_id.has_value() &&
context.functions()
.Get(callee_function.function_id)
.builtin_function_kind() != SemIR::BuiltinFunctionKind::NoOp) {
auto callee_function =
SemIR::GetCalleeFunction(context.sem_ir(), inst.callee_id);
const auto& fn = context.functions().Get(callee_function.function_id);
if (!callee_function.self_type_id.has_value() &&
fn.builtin_function_kind() != SemIR::BuiltinFunctionKind::NoOp &&
fn.virtual_modifier != SemIR::Function::VirtualModifier::Abstract) {
// This is not an associated function. Those will be required to be defined
// as part of checking that the impl is complete.
context.definitions_required_by_use().push_back(