carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 12:21:06 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Check support for form literals and :? bindings (#6747)

Browse Source 
Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
This commit is contained in:
Geoff Romer
2026-02-26 23:01:24 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins Carbon Infra Bot
parent f9ab963bd6
commit bf9219d30e
33 changed files with 1115 additions and 313 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/pattern.cpp
+21 -8
View File
@@ -48,11 +48,15 @@ auto EndSubpatternAsNonExpr(Context& context) -> void {
auto AddBindingPattern(Context& context, SemIR::LocId name_loc,
SemIR::NameId name_id, SemIR::TypeId type_id,
SemIR::ConstantId form_id,
SemIR::ExprRegionId type_region_id,
SemIR::InstKind pattern_kind, bool is_template,
bool is_unused) -> BindingPatternInfo {
SemIR::InstKind bind_name_kind;
switch (pattern_kind) {
case SemIR::InstKind::FormBindingPattern:
bind_name_kind = SemIR::InstKind::FormBinding;
break;
case SemIR::InstKind::RefBindingPattern:
bind_name_kind = SemIR::InstKind::RefBinding;
break;
@@ -63,15 +67,23 @@ auto AddBindingPattern(Context& context, SemIR::LocId name_loc,
bind_name_kind = SemIR::InstKind::ValueBinding;
break;
default:
CARBON_FATAL("pattern_kind is not a binding pattern kind");
CARBON_FATAL("pattern_kind {0} is not a binding pattern kind",
pattern_kind);
}
bool is_generic = pattern_kind == SemIR::SymbolicBindingPattern::Kind;
auto entity_name_id = context.entity_names().AddSymbolicBindingName(
name_id, context.scope_stack().PeekNameScopeId(),
is_generic ? context.scope_stack().AddCompileTimeBinding()
: SemIR::CompileTimeBindIndex::None,
is_template, is_unused || name_id == SemIR::NameId::Underscore);
SemIR::EntityName entity_name = {
.name_id = name_id,
.parent_scope_id = context.scope_stack().PeekNameScopeId(),
.is_unused = is_unused || name_id == SemIR::NameId::Underscore};
if (is_generic) {
entity_name.bind_index_value =
context.scope_stack().AddCompileTimeBinding().index;
entity_name.is_template = is_template;
} else if (pattern_kind == SemIR::InstKind::FormBindingPattern) {
entity_name.form_id = form_id;
}
auto entity_name_id = context.entity_names().Add(entity_name);
auto bind_id = AddInstInNoBlock(
context,
@@ -145,8 +157,9 @@ auto AddParamPattern(Context& context, SemIR::LocId loc_id,
const auto& binding_pattern_kind = is_ref ? SemIR::RefBindingPattern::Kind
: SemIR::ValueBindingPattern::Kind;
SemIR::InstId pattern_id =
AddBindingPattern(context, loc_id, name_id, type_id, type_expr_region_id,
binding_pattern_kind,
AddBindingPattern(context, loc_id, name_id, type_id,
/*form_id=*/SemIR::ConstantId::None,
type_expr_region_id, binding_pattern_kind,
/*is_template=*/false, /*is_unused=*/false)
.pattern_id;