mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-18 12:40:29 +00:00
Manual cleanup of toolchain clang-tidy/clangd warnings. (#3157)
A lot of this is more boring "remove unused header", plus some other minor cleanups. I think the most significant changes were: - yaml_test_helpers.cpp is doing a switch on an unsigned int, comparing to enum values. - [bugprone-switch-missing-default-case](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/switch-missing-default-case.html) is unhappy with EnumBase, but correctly identified yaml_test_helpers.cpp, so I'm opting to address it rather than disabling it even though it needs NOLINT in several locations as a result, in addition to what I think are some low-value `default` cases. I'd be fine going the other way with this too and disabling it globally (I could see it being noisier in the explorer). - MarkInitializerFor swaps the argument names between the .h and .cpp. I think the .cpp had the order as intended. - There's a new-ish [performance-enum-size](https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html) which I'm basically treating as "add int8_t to enums". My main motivation here is to just clean up as many of these as I can so that I stop seeing them in vscode.
This commit is contained in:
1 parent
2de7d262b4
commit
b9df8ca765
52 files changed
+78
-97
No files matched your search
@@ -7,13 +7,9 @@
|
||||
#include <algorithm>
|
||||
#include <array>
|
||||
#include <cmath>
|
||||
#include <iterator>
|
||||
#include <string>
|
||||
|
||||
#include "common/check.h"
|
||||
#include "common/string_helpers.h"
|
||||
#include "llvm/ADT/STLExtras.h"
|
||||
#include "llvm/ADT/Sequence.h"
|
||||
#include "llvm/ADT/StringRef.h"
|
||||
#include "llvm/ADT/StringSwitch.h"
|
||||
#include "llvm/Support/ErrorHandling.h"
|
||||
@@ -540,7 +536,7 @@ class TokenizedBuffer::Lexer {
|
||||
// Too short to form one of these tokens.
|
||||
return LexResult::NoMatch();
|
||||
}
|
||||
if (!('1' <= word[1] && word[1] <= '9')) {
|
||||
if (word[1] < '1' || word[1] > '9') {
|
||||
// Doesn't start with a valid initial digit.
|
||||
return LexResult::NoMatch();
|
||||
}
|
||||
@@ -683,6 +679,8 @@ class TokenizedBuffer::Lexer {
|
||||
case '\t':
|
||||
case '\n':
|
||||
return false;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
return llvm::StringSwitch<bool>(llvm::StringRef(&c, 1))
|
||||
#define CARBON_SYMBOL_TOKEN(Name, Spelling) .StartsWith(Spelling, false)
|
||||
|
||||
Reference in new issue
Block a user