carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-28 16:04:52 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Turn addr self in destructors into an error. (#2803)

Browse Source 
Previously crashed. See #2802
This commit is contained in:
Jon Ross-Perkins
2023-05-01 11:30:19 -07:00
committed by GitHub
parent 0732d5857d
commit b9bd7e1eff
2 changed files with 33 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/interpreter/interpreter.cpp
+9 -3
View File
@@ -944,9 +944,15 @@ auto Interpreter::CallDestructor(Nonnull<const DestructorDeclaration*> fun,
// TODO: move this logic into PatternMatch, and call it here.
const auto* p = &method.self_pattern().value();
const auto& placeholder = cast<BindingPlaceholderValue>(*p);
if (placeholder.value_node().has_value()) {
method_scope.Bind(*placeholder.value_node(), receiver);
const auto* placeholder = dyn_cast<BindingPlaceholderValue>(p);
if (!placeholder) {
// TODO: Fix this, probably merging logic with CallFunction.
// https://github.com/carbon-language/carbon-lang/issues/2802
return ProgramError(fun->source_loc())
<< "destructors currently don't support `addr self` bindings";
}
if (placeholder->value_node().has_value()) {
method_scope.Bind(*placeholder->value_node(), receiver);
}
CARBON_CHECK(method.body().has_value())
<< "Calling a method that's missing a body";