carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 10:54:49 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add support for f16, f64, f128. (#5952)

Browse Source 
Generalize the f64 support to support other sizes. Also provide interop
support for `float`, `_Float16`, and `__float128`.

Also lay some groundwork for non-standard floating-point types, though
we don't have any syntax to name them yet.
This commit is contained in:
Richard Smith
2025-08-14 01:14:40 +00:00
committed by GitHub
parent cfe5599144
commit b851e8c423
27 changed files with 826 additions and 379 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/type.cpp
+46 -21
View File
@@ -8,10 +8,10 @@
#include "toolchain/check/facet_type.h"
#include "toolchain/check/type_completion.h"
#include "toolchain/sem_ir/facet_type_info.h"
#include "toolchain/sem_ir/ids.h"
namespace Carbon::Check {
// Enforces that an integer type has a valid bit width.
auto ValidateIntType(Context& context, SemIR::LocId loc_id,
SemIR::IntType result) -> bool {
auto bit_width =
@@ -44,29 +44,54 @@ auto ValidateIntType(Context& context, SemIR::LocId loc_id,
return true;
}
// Enforces that the bit width is 64 for a float.
auto ValidateFloatBitWidth(Context& context, SemIR::LocId loc_id,
SemIR::InstId inst_id) -> bool {
auto inst = context.insts().GetAs<SemIR::IntValue>(inst_id);
if (context.ints().Get(inst.int_id) == 64) {
return true;
}
CARBON_DIAGNOSTIC(CompileTimeFloatBitWidth, Error, "bit width must be 64");
context.emitter().Emit(loc_id, CompileTimeFloatBitWidth);
return false;
}
// Enforces that a float type has a valid bit width.
auto ValidateFloatType(Context& context, SemIR::LocId loc_id,
SemIR::FloatType result) -> bool {
auto bit_width =
auto ValidateFloatTypeAndSetKind(Context& context, SemIR::LocId loc_id,
SemIR::FloatType& result) -> bool {
// Get the bit width value.
auto bit_width_inst =
context.insts().TryGetAs<SemIR::IntValue>(result.bit_width_id);
if (!bit_width) {
// Symbolic bit width.
if (!bit_width_inst) {
// Symbolic bit width. Defer checking until we have a concrete value.
return true;
}
return ValidateFloatBitWidth(context, loc_id, result.bit_width_id);
auto bit_width = context.ints().Get(bit_width_inst->int_id);
// If no kind is specified, infer kind from width.
if (!result.float_kind.has_value()) {
switch (bit_width.getLimitedValue()) {
case 16:
result.float_kind = SemIR::FloatKind::Binary16;
break;
case 32:
result.float_kind = SemIR::FloatKind::Binary32;
break;
case 64:
result.float_kind = SemIR::FloatKind::Binary64;
break;
case 128:
result.float_kind = SemIR::FloatKind::Binary128;
break;
default:
CARBON_DIAGNOSTIC(CompileTimeFloatBitWidth, Error,
"unsupported floating-point bit width {0}", TypedInt);
context.emitter().Emit(loc_id, CompileTimeFloatBitWidth,
TypedInt(bit_width_inst->type_id, bit_width));
return false;
}
}
if (llvm::APFloat::semanticsSizeInBits(result.float_kind.Semantics()) !=
bit_width) {
// This can't currently happen because we don't provide any way to set the
// float kind other than through the bit width.
// TODO: Add a float_type.make builtin that takes a float kind, and add a
// diagnostic here if the size is wrong.
context.TODO(loc_id, "wrong size for float type");
return false;
}
// TODO: Diagnose if the floating-point type is not supported on this target?
return true;
}
// Gets or forms a type_id for a type, given the instruction kind and arguments.