carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:14:43 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Reduce the new hashtable test times. (#4047)

Browse Source 
While it was convenient once to have an immediate check while inserting,
it is indeed far too quadratic. The test was taking 30-60 seconds for
me. =[ So most of the fix here is just to stop doing the check on every
insertion for all previous elements.

There were a few other somewhat slow steps, and I tried to pull those
back as well. I don't think we lose any utility here. Now everything
runs nice and quickly. =]
This commit is contained in:
Chandler Carruth
2024-06-11 03:43:18 +00:00
committed by GitHub
parent 26ead9addc
commit b773ff3695
1 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/map_test.cpp
+13 -23
View File
@@ -104,14 +104,10 @@ TYPED_TEST(MapTest, Basic) {
for (int i : llvm::seq(2, 512)) {
SCOPED_TRACE(llvm::formatv("Key: {0}", i).str());
EXPECT_TRUE(m.Insert(i, i * 100).is_inserted());
// Immediately do a basic check of all elements to pin down when an
// insertion corrupts the rest of the table.
ExpectMapElementsAre(
m,
MakeKeyValues([](int k) { return k * 100 + static_cast<int>(k == 1); },
llvm::seq_inclusive(1, i)));
}
ExpectMapElementsAre(
m, MakeKeyValues([](int k) { return k * 100 + static_cast<int>(k == 1); },
llvm::seq(1, 512)));
for (int i : llvm::seq(1, 512)) {
SCOPED_TRACE(llvm::formatv("Key: {0}", i).str());
EXPECT_FALSE(m.Insert(i, i * 100 + 1).is_inserted());
@@ -482,13 +478,9 @@ TYPED_TEST(MapCollisionTest, Basic) {
for (int i : llvm::seq(1, 256)) {
SCOPED_TRACE(llvm::formatv("Key: {0}", i).str());
EXPECT_TRUE(m.Insert(i, i * 100).is_inserted());
// Immediately do a basic check of all elements to pin down when an
// insertion corrupts the rest of the table.
ExpectMapElementsAre(m, MakeKeyValues([](int k) { return k * 100; },
llvm::seq_inclusive(1, i)));
}
EXPECT_FALSE(m.Contains(257));
ExpectMapElementsAre(
m, MakeKeyValues([](int k) { return k * 100; }, llvm::seq(1, 256)));
// Erase and re-fill from the back.
for (int i : llvm::seq(192, 256)) {
@@ -596,16 +588,14 @@ TEST(MapContextTest, Basic) {
for (int i : llvm::seq(2, 512)) {
SCOPED_TRACE(llvm::formatv("Key: {0}", i).str());
EXPECT_TRUE(m.Insert(i, i * 100, key_context).is_inserted());
// Immediately do a basic check of all elements to pin down when an
// insertion corrupts the rest of the table.
for (int j : llvm::seq(1, i)) {
SCOPED_TRACE(llvm::formatv("Assert key: {0}", j).str());
ASSERT_EQ(j * 100 + static_cast<int>(j == 1),
m.Lookup(j, key_context).value());
ASSERT_EQ(j * 100 + static_cast<int>(j == 1),
m.Lookup(TestData(j * 100000), key_context).value());
}
}
// Check all the elements, including using the context.
for (int j : llvm::seq(1, 512)) {
SCOPED_TRACE(llvm::formatv("Assert key: {0}", j).str());
ASSERT_EQ(j * 100 + static_cast<int>(j == 1),
m.Lookup(j, key_context).value());
ASSERT_EQ(j * 100 + static_cast<int>(j == 1),
m.Lookup(TestData(j * 100000), key_context).value());
}
for (int i : llvm::seq(1, 512)) {
SCOPED_TRACE(llvm::formatv("Key: {0}", i).str());