mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 08:01:05 +01:00
Don't treat dependent types as having a copy value representation. (#6055)
Add `Dependent` value and initializing representations for types whose representations are unknown because they are dependent. When generating SemIR in such cases, use a worst-case initializing representation that both provides a destination address and also propagates a potential result value. Use this to fix incorrect lowering and lowering crashes for specific functions involving generic types that don't use a copy value representation. In lowering, be careful to distinguish between whether the initializing representation for the generic return type uses a return slot (which affects whether the SemIR declaration and call have one) and whether the initializing representation for the specific return type uses a return slot (which affects whether the LLVM IR declaration and call have one).
This commit is contained in:
Richard Smith
@@ -36,11 +36,8 @@ fn M() {
|
||||
F(ptr_i32, 0);
|
||||
F(ptr_f64, 0);
|
||||
|
||||
// TODO: Crashes, hits assertion
|
||||
// `(Args.size() == FTy->getNumParams() || (FTy->isVarArg() && Args.size() > FTy->getNumParams())) && "Calling a function with bad signature!"'
|
||||
|
||||
// var c: C;
|
||||
// F(c, 0);
|
||||
var c: C;
|
||||
F(c, 0);
|
||||
}
|
||||
|
||||
// CHECK:STDOUT: ; ModuleID = 'call_recursive_basic.carbon'
|
||||
@@ -60,21 +57,26 @@ fn M() {
|
||||
// CHECK:STDOUT: %m.var = alloca double, align 8, !dbg !10
|
||||
// CHECK:STDOUT: %ptr_i32.var = alloca ptr, align 8, !dbg !11
|
||||
// CHECK:STDOUT: %ptr_f64.var = alloca ptr, align 8, !dbg !12
|
||||
// CHECK:STDOUT: %c.var = alloca {}, align 8, !dbg !13
|
||||
// CHECK:STDOUT: %.loc40_9.5.temp = alloca {}, align 8, !dbg !14
|
||||
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %n.var), !dbg !9
|
||||
// CHECK:STDOUT: store i32 0, ptr %n.var, align 4, !dbg !9
|
||||
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %m.var), !dbg !10
|
||||
// CHECK:STDOUT: store double 1.000000e+00, ptr %m.var, align 8, !dbg !10
|
||||
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %ptr_i32.var), !dbg !11
|
||||
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %ptr_f64.var), !dbg !12
|
||||
// CHECK:STDOUT: %.loc34_5 = load i32, ptr %n.var, align 4, !dbg !13
|
||||
// CHECK:STDOUT: %F.call.loc34 = call i32 @_CF.Main.de631560529e9861(i32 %.loc34_5, i32 0), !dbg !14
|
||||
// CHECK:STDOUT: %.loc35_5 = load double, ptr %m.var, align 8, !dbg !15
|
||||
// CHECK:STDOUT: %F.call.loc35 = call double @_CF.Main.3836ccc537683c19(double %.loc35_5, i32 0), !dbg !16
|
||||
// CHECK:STDOUT: %.loc36_5 = load ptr, ptr %ptr_i32.var, align 8, !dbg !17
|
||||
// CHECK:STDOUT: %F.call.loc36 = call ptr @_CF.Main.a194de4a3b8dbd0c(ptr %.loc36_5, i32 0), !dbg !18
|
||||
// CHECK:STDOUT: %.loc37_5 = load ptr, ptr %ptr_f64.var, align 8, !dbg !19
|
||||
// CHECK:STDOUT: %F.call.loc37 = call ptr @_CF.Main.a194de4a3b8dbd0c(ptr %.loc37_5, i32 0), !dbg !20
|
||||
// CHECK:STDOUT: ret void, !dbg !21
|
||||
// CHECK:STDOUT: %.loc34_5 = load i32, ptr %n.var, align 4, !dbg !15
|
||||
// CHECK:STDOUT: %F.call.loc34 = call i32 @_CF.Main.de631560529e9861(i32 %.loc34_5, i32 0), !dbg !16
|
||||
// CHECK:STDOUT: %.loc35_5 = load double, ptr %m.var, align 8, !dbg !17
|
||||
// CHECK:STDOUT: %F.call.loc35 = call double @_CF.Main.3836ccc537683c19(double %.loc35_5, i32 0), !dbg !18
|
||||
// CHECK:STDOUT: %.loc36_5 = load ptr, ptr %ptr_i32.var, align 8, !dbg !19
|
||||
// CHECK:STDOUT: %F.call.loc36 = call ptr @_CF.Main.a194de4a3b8dbd0c(ptr %.loc36_5, i32 0), !dbg !20
|
||||
// CHECK:STDOUT: %.loc37_5 = load ptr, ptr %ptr_f64.var, align 8, !dbg !21
|
||||
// CHECK:STDOUT: %F.call.loc37 = call ptr @_CF.Main.a194de4a3b8dbd0c(ptr %.loc37_5, i32 0), !dbg !22
|
||||
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %c.var), !dbg !13
|
||||
// CHECK:STDOUT: call void @llvm.lifetime.start.p0(ptr %.loc40_9.5.temp), !dbg !14
|
||||
// CHECK:STDOUT: call void @_CF.Main.936d996ea935415c(ptr %.loc40_9.5.temp, ptr %c.var, i32 0), !dbg !14
|
||||
// CHECK:STDOUT: ret void, !dbg !23
|
||||
// CHECK:STDOUT: }
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: ; Function Attrs: nocallback nofree nounwind willreturn memory(argmem: readwrite)
|
||||
@@ -83,50 +85,65 @@ fn M() {
|
||||
// CHECK:STDOUT: ; Function Attrs: nocallback nofree nosync nounwind willreturn memory(argmem: readwrite)
|
||||
// CHECK:STDOUT: declare void @llvm.lifetime.start.p0(ptr captures(none)) #1
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: define linkonce_odr i32 @_CF.Main.de631560529e9861(i32 %x, i32 %count) !dbg !22 {
|
||||
// CHECK:STDOUT: define linkonce_odr i32 @_CF.Main.de631560529e9861(i32 %x, i32 %count) !dbg !24 {
|
||||
// CHECK:STDOUT: entry:
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !23
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !24
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !25
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !26
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.then: ; preds = %entry
|
||||
// CHECK:STDOUT: ret i32 %x, !dbg !25
|
||||
// CHECK:STDOUT: ret i32 %x, !dbg !27
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.else: ; preds = %entry
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !26
|
||||
// CHECK:STDOUT: %F.call = call i32 @_CF.Main.de631560529e9861(i32 %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !27
|
||||
// CHECK:STDOUT: ret i32 %F.call, !dbg !28
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !28
|
||||
// CHECK:STDOUT: %F.call = call i32 @_CF.Main.de631560529e9861(i32 %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !29
|
||||
// CHECK:STDOUT: ret i32 %F.call, !dbg !30
|
||||
// CHECK:STDOUT: }
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: define linkonce_odr double @_CF.Main.3836ccc537683c19(double %x, i32 %count) !dbg !29 {
|
||||
// CHECK:STDOUT: define linkonce_odr double @_CF.Main.3836ccc537683c19(double %x, i32 %count) !dbg !31 {
|
||||
// CHECK:STDOUT: entry:
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !30
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !31
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !32
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !33
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.then: ; preds = %entry
|
||||
// CHECK:STDOUT: ret double %x, !dbg !32
|
||||
// CHECK:STDOUT: ret double %x, !dbg !34
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.else: ; preds = %entry
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !33
|
||||
// CHECK:STDOUT: %F.call = call double @_CF.Main.3836ccc537683c19(double %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !34
|
||||
// CHECK:STDOUT: ret double %F.call, !dbg !35
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !35
|
||||
// CHECK:STDOUT: %F.call = call double @_CF.Main.3836ccc537683c19(double %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !36
|
||||
// CHECK:STDOUT: ret double %F.call, !dbg !37
|
||||
// CHECK:STDOUT: }
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: define linkonce_odr ptr @_CF.Main.a194de4a3b8dbd0c(ptr %x, i32 %count) !dbg !36 {
|
||||
// CHECK:STDOUT: define linkonce_odr ptr @_CF.Main.a194de4a3b8dbd0c(ptr %x, i32 %count) !dbg !38 {
|
||||
// CHECK:STDOUT: entry:
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !37
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !38
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !39
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !40
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.then: ; preds = %entry
|
||||
// CHECK:STDOUT: ret ptr %x, !dbg !39
|
||||
// CHECK:STDOUT: ret ptr %x, !dbg !41
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.else: ; preds = %entry
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !40
|
||||
// CHECK:STDOUT: %F.call = call ptr @_CF.Main.a194de4a3b8dbd0c(ptr %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !41
|
||||
// CHECK:STDOUT: ret ptr %F.call, !dbg !42
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !42
|
||||
// CHECK:STDOUT: %F.call = call ptr @_CF.Main.a194de4a3b8dbd0c(ptr %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !43
|
||||
// CHECK:STDOUT: ret ptr %F.call, !dbg !44
|
||||
// CHECK:STDOUT: }
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: define linkonce_odr void @_CF.Main.936d996ea935415c(ptr sret({}) %return, ptr %x, i32 %count) !dbg !45 {
|
||||
// CHECK:STDOUT: entry:
|
||||
// CHECK:STDOUT: %Int.as.OrderedWith.impl.Greater.call = icmp sgt i32 %count, 0, !dbg !46
|
||||
// CHECK:STDOUT: br i1 %Int.as.OrderedWith.impl.Greater.call, label %if.then, label %if.else, !dbg !47
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.then: ; preds = %entry
|
||||
// CHECK:STDOUT: call void @"_COp.C.Main:Copy.Core"(ptr %return, ptr %x), !dbg !48
|
||||
// CHECK:STDOUT: ret void, !dbg !49
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: if.else: ; preds = %entry
|
||||
// CHECK:STDOUT: %Int.as.AddWith.impl.Op.call = add i32 %count, 1, !dbg !50
|
||||
// CHECK:STDOUT: call void @_CF.Main.936d996ea935415c(ptr %return, ptr %x, i32 %Int.as.AddWith.impl.Op.call), !dbg !51
|
||||
// CHECK:STDOUT: ret void, !dbg !52
|
||||
// CHECK:STDOUT: }
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: ; uselistorder directives
|
||||
// CHECK:STDOUT: uselistorder ptr @llvm.lifetime.start.p0, { 3, 2, 1, 0 }
|
||||
// CHECK:STDOUT: uselistorder ptr @llvm.lifetime.start.p0, { 5, 4, 3, 2, 1, 0 }
|
||||
// CHECK:STDOUT: uselistorder ptr @_CF.Main.a194de4a3b8dbd0c, { 1, 2, 0 }
|
||||
// CHECK:STDOUT:
|
||||
// CHECK:STDOUT: attributes #0 = { nocallback nofree nounwind willreturn memory(argmem: readwrite) }
|
||||
@@ -148,33 +165,43 @@ fn M() {
|
||||
// CHECK:STDOUT: !10 = !DILocation(line: 30, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !11 = !DILocation(line: 31, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !12 = !DILocation(line: 32, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !13 = !DILocation(line: 34, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !14 = !DILocation(line: 34, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !15 = !DILocation(line: 35, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !16 = !DILocation(line: 35, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !17 = !DILocation(line: 36, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !18 = !DILocation(line: 36, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !19 = !DILocation(line: 37, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !20 = !DILocation(line: 37, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !21 = !DILocation(line: 28, column: 1, scope: !8)
|
||||
// CHECK:STDOUT: !22 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.de631560529e9861", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !23 = !DILocation(line: 22, column: 7, scope: !22)
|
||||
// CHECK:STDOUT: !24 = !DILocation(line: 22, column: 6, scope: !22)
|
||||
// CHECK:STDOUT: !25 = !DILocation(line: 23, column: 5, scope: !22)
|
||||
// CHECK:STDOUT: !26 = !DILocation(line: 25, column: 15, scope: !22)
|
||||
// CHECK:STDOUT: !27 = !DILocation(line: 25, column: 10, scope: !22)
|
||||
// CHECK:STDOUT: !28 = !DILocation(line: 25, column: 3, scope: !22)
|
||||
// CHECK:STDOUT: !29 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.3836ccc537683c19", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !30 = !DILocation(line: 22, column: 7, scope: !29)
|
||||
// CHECK:STDOUT: !31 = !DILocation(line: 22, column: 6, scope: !29)
|
||||
// CHECK:STDOUT: !32 = !DILocation(line: 23, column: 5, scope: !29)
|
||||
// CHECK:STDOUT: !33 = !DILocation(line: 25, column: 15, scope: !29)
|
||||
// CHECK:STDOUT: !34 = !DILocation(line: 25, column: 10, scope: !29)
|
||||
// CHECK:STDOUT: !35 = !DILocation(line: 25, column: 3, scope: !29)
|
||||
// CHECK:STDOUT: !36 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.a194de4a3b8dbd0c", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !37 = !DILocation(line: 22, column: 7, scope: !36)
|
||||
// CHECK:STDOUT: !38 = !DILocation(line: 22, column: 6, scope: !36)
|
||||
// CHECK:STDOUT: !39 = !DILocation(line: 23, column: 5, scope: !36)
|
||||
// CHECK:STDOUT: !40 = !DILocation(line: 25, column: 15, scope: !36)
|
||||
// CHECK:STDOUT: !41 = !DILocation(line: 25, column: 10, scope: !36)
|
||||
// CHECK:STDOUT: !42 = !DILocation(line: 25, column: 3, scope: !36)
|
||||
// CHECK:STDOUT: !13 = !DILocation(line: 39, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !14 = !DILocation(line: 40, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !15 = !DILocation(line: 34, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !16 = !DILocation(line: 34, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !17 = !DILocation(line: 35, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !18 = !DILocation(line: 35, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !19 = !DILocation(line: 36, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !20 = !DILocation(line: 36, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !21 = !DILocation(line: 37, column: 5, scope: !8)
|
||||
// CHECK:STDOUT: !22 = !DILocation(line: 37, column: 3, scope: !8)
|
||||
// CHECK:STDOUT: !23 = !DILocation(line: 28, column: 1, scope: !8)
|
||||
// CHECK:STDOUT: !24 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.de631560529e9861", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !25 = !DILocation(line: 22, column: 7, scope: !24)
|
||||
// CHECK:STDOUT: !26 = !DILocation(line: 22, column: 6, scope: !24)
|
||||
// CHECK:STDOUT: !27 = !DILocation(line: 23, column: 5, scope: !24)
|
||||
// CHECK:STDOUT: !28 = !DILocation(line: 25, column: 15, scope: !24)
|
||||
// CHECK:STDOUT: !29 = !DILocation(line: 25, column: 10, scope: !24)
|
||||
// CHECK:STDOUT: !30 = !DILocation(line: 25, column: 3, scope: !24)
|
||||
// CHECK:STDOUT: !31 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.3836ccc537683c19", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !32 = !DILocation(line: 22, column: 7, scope: !31)
|
||||
// CHECK:STDOUT: !33 = !DILocation(line: 22, column: 6, scope: !31)
|
||||
// CHECK:STDOUT: !34 = !DILocation(line: 23, column: 5, scope: !31)
|
||||
// CHECK:STDOUT: !35 = !DILocation(line: 25, column: 15, scope: !31)
|
||||
// CHECK:STDOUT: !36 = !DILocation(line: 25, column: 10, scope: !31)
|
||||
// CHECK:STDOUT: !37 = !DILocation(line: 25, column: 3, scope: !31)
|
||||
// CHECK:STDOUT: !38 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.a194de4a3b8dbd0c", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !39 = !DILocation(line: 22, column: 7, scope: !38)
|
||||
// CHECK:STDOUT: !40 = !DILocation(line: 22, column: 6, scope: !38)
|
||||
// CHECK:STDOUT: !41 = !DILocation(line: 23, column: 5, scope: !38)
|
||||
// CHECK:STDOUT: !42 = !DILocation(line: 25, column: 15, scope: !38)
|
||||
// CHECK:STDOUT: !43 = !DILocation(line: 25, column: 10, scope: !38)
|
||||
// CHECK:STDOUT: !44 = !DILocation(line: 25, column: 3, scope: !38)
|
||||
// CHECK:STDOUT: !45 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main.936d996ea935415c", scope: null, file: !3, line: 21, type: !5, spFlags: DISPFlagDefinition, unit: !2)
|
||||
// CHECK:STDOUT: !46 = !DILocation(line: 22, column: 7, scope: !45)
|
||||
// CHECK:STDOUT: !47 = !DILocation(line: 22, column: 6, scope: !45)
|
||||
// CHECK:STDOUT: !48 = !DILocation(line: 23, column: 12, scope: !45)
|
||||
// CHECK:STDOUT: !49 = !DILocation(line: 23, column: 5, scope: !45)
|
||||
// CHECK:STDOUT: !50 = !DILocation(line: 25, column: 15, scope: !45)
|
||||
// CHECK:STDOUT: !51 = !DILocation(line: 25, column: 10, scope: !45)
|
||||
// CHECK:STDOUT: !52 = !DILocation(line: 25, column: 3, scope: !45)
|
||||
|
||||
Reference in New Issue
Block a user