carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-03 22:02:51 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add a global arena to start cleaning up ASAN errors (#687)

Browse Source
This commit is contained in:
Jon Meow
2021-07-30 10:56:53 -07:00
committed by GitHub
parent 2f023b3479
commit b08f6bb0f1
7 changed files with 98 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
executable_semantics/ast/expression.cpp
+16 -15
View File
@@ -4,6 +4,7 @@
#include "executable_semantics/ast/expression.h"
#include "executable_semantics/common/arena.h"
#include "executable_semantics/common/error.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/raw_ostream.h"
@@ -54,28 +55,28 @@ auto Expression::GetFunctionTypeLiteral() const -> const FunctionTypeLiteral& {
}
auto Expression::MakeTypeTypeLiteral(int line_num) -> const Expression* {
auto* t = new Expression();
auto* t = global_arena->New<Expression>();
t->line_num = line_num;
t->value = TypeTypeLiteral();
return t;
}
auto Expression::MakeIntTypeLiteral(int line_num) -> const Expression* {
auto* t = new Expression();
auto* t = global_arena->New<Expression>();
t->line_num = line_num;
t->value = IntTypeLiteral();
return t;
}
auto Expression::MakeBoolTypeLiteral(int line_num) -> const Expression* {
auto* t = new Expression();
auto* t = global_arena->New<Expression>();
t->line_num = line_num;
t->value = BoolTypeLiteral();
return t;
}
auto Expression::MakeAutoTypeLiteral(int line_num) -> const Expression* {
auto* t = new Expression();
auto* t = global_arena->New<Expression>();
t->line_num = line_num;
t->value = AutoTypeLiteral();
return t;
@@ -84,7 +85,7 @@ auto Expression::MakeAutoTypeLiteral(int line_num) -> const Expression* {
// Returns a Continuation type AST node at the given source location.
auto Expression::MakeContinuationTypeLiteral(int line_num)
-> const Expression* {
auto* type = new Expression();
auto* type = global_arena->New<Expression>();
type->line_num = line_num;
type->value = ContinuationTypeLiteral();
return type;
@@ -93,7 +94,7 @@ auto Expression::MakeContinuationTypeLiteral(int line_num)
auto Expression::MakeFunctionTypeLiteral(int line_num, const Expression* param,
const Expression* ret)
-> const Expression* {
auto* t = new Expression();
auto* t = global_arena->New<Expression>();
t->line_num = line_num;
t->value = FunctionTypeLiteral({.parameter = param, .return_type = ret});
return t;
@@ -101,7 +102,7 @@ auto Expression::MakeFunctionTypeLiteral(int line_num, const Expression* param,
auto Expression::MakeIdentifierExpression(int line_num, std::string var)
-> const Expression* {
auto* v = new Expression();
auto* v = global_arena->New<Expression>();
v->line_num = line_num;
v->value = IdentifierExpression({.name = std::move(var)});
return v;
@@ -111,21 +112,21 @@ auto Expression::MakeBindingExpression(int line_num,
std::optional<std::string> var,
const Expression* type)
-> const Expression* {
auto* v = new Expression();
auto* v = global_arena->New<Expression>();
v->line_num = line_num;
v->value = BindingExpression({.name = std::move(var), .type = type});
return v;
}
auto Expression::MakeIntLiteral(int line_num, int i) -> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
e->value = IntLiteral({.value = i});
return e;
}
auto Expression::MakeBoolLiteral(int line_num, bool b) -> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
e->value = BoolLiteral({.value = b});
return e;
@@ -134,7 +135,7 @@ auto Expression::MakeBoolLiteral(int line_num, bool b) -> const Expression* {
auto Expression::MakePrimitiveOperatorExpression(
int line_num, enum Operator op, std::vector<const Expression*> args)
-> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
e->value =
PrimitiveOperatorExpression({.op = op, .arguments = std::move(args)});
@@ -144,7 +145,7 @@ auto Expression::MakePrimitiveOperatorExpression(
auto Expression::MakeCallExpression(int line_num, const Expression* fun,
const Expression* arg)
-> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
e->value = CallExpression({.function = fun, .argument = arg});
return e;
@@ -153,7 +154,7 @@ auto Expression::MakeCallExpression(int line_num, const Expression* fun,
auto Expression::MakeFieldAccessExpression(int line_num, const Expression* exp,
std::string field)
-> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
e->value =
FieldAccessExpression({.aggregate = exp, .field = std::move(field)});
@@ -163,7 +164,7 @@ auto Expression::MakeFieldAccessExpression(int line_num, const Expression* exp,
auto Expression::MakeTupleLiteral(int line_num,
std::vector<FieldInitializer> args)
-> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
int i = 0;
bool seen_named_member = false;
@@ -185,7 +186,7 @@ auto Expression::MakeTupleLiteral(int line_num,
auto Expression::MakeIndexExpression(int line_num, const Expression* exp,
const Expression* i) -> const Expression* {
auto* e = new Expression();
auto* e = global_arena->New<Expression>();
e->line_num = line_num;
e->value = IndexExpression({.aggregate = exp, .offset = i});
return e;