carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-02 14:26:02 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Cleanup or suppress numerous clang-tidy issues. (#577)

Browse Source 
This gets us to a nearly clean state across the toolchain. A couple of
these are checks that I don't think we want to try to rigidly use and
I've disabled them completely. Others I've added relevant `NOLINT` style
suppressions or applied the automatic fix suggested by `clang-tidy`.

The implicit conversions that are allowed here with `NOLINT` are
probably worth at least a tiny bit of scrutiny to see if we could
replace the construct with something more direct without undue effort
and no longer need the implicit conversion. But until then, it seemed
fine to suppress.
This commit is contained in:
Chandler Carruth
2021-06-14 19:46:49 -07:00
committed by GitHub
parent 1b122924e8
commit a857b7ea1a
16 changed files with 60 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parser/parser_impl.cpp
+5 -5
View File
@@ -650,7 +650,7 @@ auto ParseTree::Parser::ParseParenExpression() -> llvm::Optional<Node> {
ParseCloseParen(open_paren, ParseNodeKind::ParenExpressionEnd());
return AddNode(ParseNodeKind::ParenExpression(), open_paren, start,
/*has_errors=*/!expr || !close_paren);
/*has_error=*/!expr || !close_paren);
}
auto ParseTree::Parser::ParsePrimaryExpression() -> llvm::Optional<Node> {
@@ -971,7 +971,7 @@ auto ParseTree::Parser::ParseParenCondition(TokenKind introducer)
ParseCloseParen(*open_paren, ParseNodeKind::ConditionEnd());
return AddNode(ParseNodeKind::Condition(), *open_paren, start,
/*has_errors=*/!expr || !close_paren);
/*has_error=*/!expr || !close_paren);
}
auto ParseTree::Parser::ParseIfStatement() -> llvm::Optional<Node> {
@@ -985,7 +985,7 @@ auto ParseTree::Parser::ParseIfStatement() -> llvm::Optional<Node> {
else_has_errors = !ParseStatement();
}
return AddNode(ParseNodeKind::IfStatement(), if_token, start,
/*has_errors=*/!cond || !then_case || else_has_errors);
/*has_error=*/!cond || !then_case || else_has_errors);
}
auto ParseTree::Parser::ParseWhileStatement() -> llvm::Optional<Node> {
@@ -994,7 +994,7 @@ auto ParseTree::Parser::ParseWhileStatement() -> llvm::Optional<Node> {
auto cond = ParseParenCondition(TokenKind::WhileKeyword());
auto body = ParseStatement();
return AddNode(ParseNodeKind::WhileStatement(), while_token, start,
/*has_errors=*/!cond || !body);
/*has_error=*/!cond || !body);
}
auto ParseTree::Parser::ParseKeywordStatement(ParseNodeKind kind,
@@ -1020,7 +1020,7 @@ auto ParseTree::Parser::ParseKeywordStatement(ParseNodeKind kind,
{.preceding = keyword_kind});
// FIXME: Try to skip to a semicolon to recover.
}
return AddNode(kind, keyword, start, /*has_errors=*/!semi || arg_error);
return AddNode(kind, keyword, start, /*has_error=*/!semi || arg_error);
}
auto ParseTree::Parser::ParseStatement() -> llvm::Optional<Node> {