carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 06:54:44 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Added string indexing (#6329)

Browse Source 
Implemented string indexing for Core.string
Handles references or struct values. No runtime checks as per
https://discord.com/channels/655572317891461132/655578254970716160/1431015866270748682
Part of #6270

---------

Co-authored-by: Dana Jansens <danakj@orodu.net>
This commit is contained in:
Ammar Alassal
2025-12-11 21:31:31 +00:00
committed by GitHub
co-authored by Dana Jansens
parent 35d505a985
commit a848ae11e4
8 changed files with 389 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/sem_ir/builtin_function_kind.cpp
+35
View File
@@ -192,6 +192,36 @@ struct AnyType {
}
};
// Constraint that checks if a type is Core.String.
struct CoreStringType {
static auto CheckType(const File& sem_ir, ValidateState& /*state*/,
TypeId type_id) -> bool {
auto type_inst_id = sem_ir.types().GetInstId(type_id);
auto class_type = sem_ir.insts().TryGetAs<ClassType>(type_inst_id);
if (!class_type) {
return false;
}
const auto& class_info = sem_ir.classes().Get(class_type->class_id);
return sem_ir.names().GetFormatted(class_info.name_id).str() == "String";
}
};
// Constraint that checks if a type is Core.Char.
struct CoreCharType {
static auto CheckType(const File& sem_ir, ValidateState& /*state*/,
TypeId type_id) -> bool {
auto type_inst_id = sem_ir.types().GetInstId(type_id);
auto class_type = sem_ir.insts().TryGetAs<ClassType>(type_inst_id);
if (!class_type) {
return false;
}
const auto& class_info = sem_ir.classes().Get(class_type->class_id);
return sem_ir.names().GetFormatted(class_info.name_id).str() == "Char";
}
};
// Constraint that requires the type to be the type type.
using Type = BuiltinType<TypeType::TypeInstId>;
@@ -373,6 +403,11 @@ constexpr BuiltinInfo PrintInt = {
constexpr BuiltinInfo ReadChar = {"read.char",
ValidateSignature<auto()->AnySizedInt>};
// Gets a character from a string at the given index.
constexpr BuiltinInfo StringAt = {
"string.at",
ValidateSignature<auto(CoreStringType, AnyType)->CoreCharType>};
// Returns the `Core.CharLiteral` type.
constexpr BuiltinInfo CharLiteralMakeType = {"char_literal.make_type",
ValidateSignature<auto()->Type>};