From a5cee5223963fb456ac03b72fa55477d90e1ea8d Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Fri, 1 Oct 2021 20:07:23 -0700 Subject: [PATCH] Fix a typo in the spelling of the libc++ debug macro. (#868) This should get us actual debugging capabilities. Also, adopt the better bazel formulation that I forgot to add from geoffromer's original change. --- bazel/cc_toolchains/clang_cc_toolchain_config.bzl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bazel/cc_toolchains/clang_cc_toolchain_config.bzl b/bazel/cc_toolchains/clang_cc_toolchain_config.bzl index a7f7d96fb3e0..9330a302adb3 100644 --- a/bazel/cc_toolchains/clang_cc_toolchain_config.bzl +++ b/bazel/cc_toolchains/clang_cc_toolchain_config.bzl @@ -528,11 +528,10 @@ def _impl(ctx): actions = all_compile_actions, flag_groups = [flag_group(flags = [ # Enable libc++'s debug features. - "-D_LIBCXX_DEBUG=1", + "-D_LIBCPP_DEBUG=1", ])], with_features = [ - with_feature_set(features = ["dbg"]), - with_feature_set(features = ["fastbuild"]), + with_feature_set(not_features = ["opt"]), ], ), ],