carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rudimentary name mangling support (#4267)

Browse Source 
This seems to be enough to avoid naming collisions for functions in any
of the current test cases (verified by asserting that the name of the
`llvm::Function` matches the name passed to create it - not triggering
LLVM's numbering that happens when names collide)

It currently implements mangling for namespace scopes, class scopes, and
impls.
Nothing generic is mangled yet - haven't looked at how that works,
though evidently it's not covered by existing testing, I guess.

Follow-up change will document the current mangling algorithm in
`toolchain/docs/lower.md`

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
This commit is contained in:
David Blaikie
2024-09-06 23:10:21 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins Carbon Infra Bot
parent 49f2136325
commit a548eff0bb
94 changed files with 657 additions and 498 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/testdata/while/break_continue.carbon
Vendored
+8 -8
View File
@@ -22,29 +22,29 @@ fn While() {
// CHECK:STDOUT: ; ModuleID = 'break_continue.carbon'
// CHECK:STDOUT: source_filename = "break_continue.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: declare i1 @A()
// CHECK:STDOUT: declare i1 @_CA.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare i1 @B()
// CHECK:STDOUT: declare i1 @_CB.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare i1 @C()
// CHECK:STDOUT: declare i1 @_CC.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: define void @While() !dbg !4 {
// CHECK:STDOUT: define void @_CWhile.Main() !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: br label %while.cond
// CHECK:STDOUT:
// CHECK:STDOUT: while.cond: ; preds = %entry, %if.else.loc18, %if.then.loc17
// CHECK:STDOUT: %A.call = call i1 @A(), !dbg !7
// CHECK:STDOUT: %A.call = call i1 @_CA.Main(), !dbg !7
// CHECK:STDOUT: br i1 %A.call, label %while.body, label %while.done, !dbg !8
// CHECK:STDOUT:
// CHECK:STDOUT: while.body: ; preds = %while.cond
// CHECK:STDOUT: %B.call = call i1 @B(), !dbg !9
// CHECK:STDOUT: %B.call = call i1 @_CB.Main(), !dbg !9
// CHECK:STDOUT: br i1 %B.call, label %if.then.loc17, label %if.else.loc17, !dbg !10
// CHECK:STDOUT:
// CHECK:STDOUT: if.then.loc17: ; preds = %while.body
// CHECK:STDOUT: br label %while.cond, !dbg !11
// CHECK:STDOUT:
// CHECK:STDOUT: if.else.loc17: ; preds = %while.body
// CHECK:STDOUT: %C.call = call i1 @C(), !dbg !12
// CHECK:STDOUT: %C.call = call i1 @_CC.Main(), !dbg !12
// CHECK:STDOUT: br i1 %C.call, label %if.then.loc18, label %if.else.loc18, !dbg !13
// CHECK:STDOUT:
// CHECK:STDOUT: if.then.loc18: ; preds = %if.else.loc17
@@ -67,7 +67,7 @@ fn While() {
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
// CHECK:STDOUT: !3 = !DIFile(filename: "break_continue.carbon", directory: "")
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "While", scope: null, file: !3, line: 15, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "_CWhile.Main", scope: null, file: !3, line: 15, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
// CHECK:STDOUT: !6 = !{}
// CHECK:STDOUT: !7 = !DILocation(line: 16, column: 10, scope: !4)
toolchain/lower/testdata/while/preheader.carbon
Vendored
+10 -10
View File
@@ -31,34 +31,34 @@ fn While() {
// CHECK:STDOUT: ; ModuleID = 'preheader.carbon'
// CHECK:STDOUT: source_filename = "preheader.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: declare i1 @Cond()
// CHECK:STDOUT: declare i1 @_CCond.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @F()
// CHECK:STDOUT: declare void @_CF.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @G()
// CHECK:STDOUT: declare void @_CG.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: define void @While() !dbg !4 {
// CHECK:STDOUT: define void @_CWhile.Main() !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: br label %while.cond.loc20
// CHECK:STDOUT:
// CHECK:STDOUT: while.cond.loc20: ; preds = %entry, %while.body.loc20
// CHECK:STDOUT: %Cond.call.loc20 = call i1 @Cond(), !dbg !7
// CHECK:STDOUT: %Cond.call.loc20 = call i1 @_CCond.Main(), !dbg !7
// CHECK:STDOUT: br i1 %Cond.call.loc20, label %while.body.loc20, label %while.done.loc20, !dbg !8
// CHECK:STDOUT:
// CHECK:STDOUT: while.body.loc20: ; preds = %while.cond.loc20
// CHECK:STDOUT: call void @F(), !dbg !9
// CHECK:STDOUT: call void @_CF.Main(), !dbg !9
// CHECK:STDOUT: br label %while.cond.loc20, !dbg !10
// CHECK:STDOUT:
// CHECK:STDOUT: while.done.loc20: ; preds = %while.cond.loc20
// CHECK:STDOUT: %Cond.call.loc24 = call i1 @Cond(), !dbg !11
// CHECK:STDOUT: %Cond.call.loc24 = call i1 @_CCond.Main(), !dbg !11
// CHECK:STDOUT: br i1 %Cond.call.loc24, label %while.cond.loc25, label %if.else, !dbg !12
// CHECK:STDOUT:
// CHECK:STDOUT: while.cond.loc25: ; preds = %while.body.loc25, %while.done.loc20
// CHECK:STDOUT: %Cond.call.loc25 = call i1 @Cond(), !dbg !13
// CHECK:STDOUT: %Cond.call.loc25 = call i1 @_CCond.Main(), !dbg !13
// CHECK:STDOUT: br i1 %Cond.call.loc25, label %while.body.loc25, label %while.done.loc25, !dbg !14
// CHECK:STDOUT:
// CHECK:STDOUT: while.body.loc25: ; preds = %while.cond.loc25
// CHECK:STDOUT: call void @G(), !dbg !15
// CHECK:STDOUT: call void @_CG.Main(), !dbg !15
// CHECK:STDOUT: br label %while.cond.loc25, !dbg !16
// CHECK:STDOUT:
// CHECK:STDOUT: while.done.loc25: ; preds = %while.cond.loc25
@@ -78,7 +78,7 @@ fn While() {
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
// CHECK:STDOUT: !3 = !DIFile(filename: "preheader.carbon", directory: "")
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "While", scope: null, file: !3, line: 19, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "_CWhile.Main", scope: null, file: !3, line: 19, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
// CHECK:STDOUT: !6 = !{}
// CHECK:STDOUT: !7 = !DILocation(line: 20, column: 10, scope: !4)
toolchain/lower/testdata/while/unreachable_end.carbon
Vendored
+10 -10
View File
@@ -26,29 +26,29 @@ fn While() {
// CHECK:STDOUT: ; ModuleID = 'unreachable_end.carbon'
// CHECK:STDOUT: source_filename = "unreachable_end.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: declare i1 @Cond()
// CHECK:STDOUT: declare i1 @_CCond.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @F()
// CHECK:STDOUT: declare void @_CF.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @G()
// CHECK:STDOUT: declare void @_CG.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @H()
// CHECK:STDOUT: declare void @_CH.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: define void @While() !dbg !4 {
// CHECK:STDOUT: define void @_CWhile.Main() !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: call void @F(), !dbg !7
// CHECK:STDOUT: call void @_CF.Main(), !dbg !7
// CHECK:STDOUT: br label %while.cond, !dbg !8
// CHECK:STDOUT:
// CHECK:STDOUT: while.cond: ; preds = %entry
// CHECK:STDOUT: %Cond.call = call i1 @Cond(), !dbg !9
// CHECK:STDOUT: %Cond.call = call i1 @_CCond.Main(), !dbg !9
// CHECK:STDOUT: br i1 %Cond.call, label %while.body, label %while.done, !dbg !8
// CHECK:STDOUT:
// CHECK:STDOUT: while.body: ; preds = %while.cond
// CHECK:STDOUT: call void @G(), !dbg !10
// CHECK:STDOUT: call void @_CG.Main(), !dbg !10
// CHECK:STDOUT: ret void, !dbg !11
// CHECK:STDOUT:
// CHECK:STDOUT: while.done: ; preds = %while.cond
// CHECK:STDOUT: call void @H(), !dbg !12
// CHECK:STDOUT: call void @_CH.Main(), !dbg !12
// CHECK:STDOUT: ret void, !dbg !13
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -59,7 +59,7 @@ fn While() {
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
// CHECK:STDOUT: !3 = !DIFile(filename: "unreachable_end.carbon", directory: "")
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "While", scope: null, file: !3, line: 17, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "_CWhile.Main", scope: null, file: !3, line: 17, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
// CHECK:STDOUT: !6 = !{}
// CHECK:STDOUT: !7 = !DILocation(line: 18, column: 3, scope: !4)
toolchain/lower/testdata/while/while.carbon
Vendored
+10 -10
View File
@@ -25,29 +25,29 @@ fn While() {
// CHECK:STDOUT: ; ModuleID = 'while.carbon'
// CHECK:STDOUT: source_filename = "while.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: declare i1 @Cond()
// CHECK:STDOUT: declare i1 @_CCond.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @F()
// CHECK:STDOUT: declare void @_CF.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @G()
// CHECK:STDOUT: declare void @_CG.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: declare void @H()
// CHECK:STDOUT: declare void @_CH.Main()
// CHECK:STDOUT:
// CHECK:STDOUT: define void @While() !dbg !4 {
// CHECK:STDOUT: define void @_CWhile.Main() !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: call void @F(), !dbg !7
// CHECK:STDOUT: call void @_CF.Main(), !dbg !7
// CHECK:STDOUT: br label %while.cond, !dbg !8
// CHECK:STDOUT:
// CHECK:STDOUT: while.cond: ; preds = %while.body, %entry
// CHECK:STDOUT: %Cond.call = call i1 @Cond(), !dbg !9
// CHECK:STDOUT: %Cond.call = call i1 @_CCond.Main(), !dbg !9
// CHECK:STDOUT: br i1 %Cond.call, label %while.body, label %while.done, !dbg !8
// CHECK:STDOUT:
// CHECK:STDOUT: while.body: ; preds = %while.cond
// CHECK:STDOUT: call void @G(), !dbg !10
// CHECK:STDOUT: call void @_CG.Main(), !dbg !10
// CHECK:STDOUT: br label %while.cond, !dbg !11
// CHECK:STDOUT:
// CHECK:STDOUT: while.done: ; preds = %while.cond
// CHECK:STDOUT: call void @H(), !dbg !12
// CHECK:STDOUT: call void @_CH.Main(), !dbg !12
// CHECK:STDOUT: ret void, !dbg !13
// CHECK:STDOUT: }
// CHECK:STDOUT:
@@ -58,7 +58,7 @@ fn While() {
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
// CHECK:STDOUT: !3 = !DIFile(filename: "while.carbon", directory: "")
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "While", scope: null, file: !3, line: 17, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "While", linkageName: "_CWhile.Main", scope: null, file: !3, line: 17, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
// CHECK:STDOUT: !6 = !{}
// CHECK:STDOUT: !7 = !DILocation(line: 18, column: 3, scope: !4)