carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 08:14:43 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rudimentary name mangling support (#4267)

Browse Source 
This seems to be enough to avoid naming collisions for functions in any
of the current test cases (verified by asserting that the name of the
`llvm::Function` matches the name passed to create it - not triggering
LLVM's numbering that happens when names collide)

It currently implements mangling for namespace scopes, class scopes, and
impls.
Nothing generic is mangled yet - haven't looked at how that works,
though evidently it's not covered by existing testing, I guess.

Follow-up change will document the current mangling algorithm in
`toolchain/docs/lower.md`

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
This commit is contained in:
David Blaikie
2024-09-06 23:10:21 +00:00
committed by GitHub
co-authored by Jon Ross-Perkins Carbon Infra Bot
parent 49f2136325
commit a548eff0bb
94 changed files with 657 additions and 498 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/testdata/if_expr/basic.carbon
Vendored
+8 -8
View File
@@ -18,26 +18,26 @@ fn Select(b: bool) -> i32 {
// CHECK:STDOUT: ; ModuleID = 'basic.carbon'
// CHECK:STDOUT: source_filename = "basic.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: define i32 @F() !dbg !4 {
// CHECK:STDOUT: define i32 @_CF.Main() !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: ret i32 1, !dbg !7
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: define i32 @G() !dbg !8 {
// CHECK:STDOUT: define i32 @_CG.Main() !dbg !8 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: ret i32 2, !dbg !9
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: define i32 @Select(i1 %b) !dbg !10 {
// CHECK:STDOUT: define i32 @_CSelect.Main(i1 %b) !dbg !10 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: br i1 %b, label %if.expr.then, label %if.expr.else, !dbg !11
// CHECK:STDOUT:
// CHECK:STDOUT: if.expr.then: ; preds = %entry
// CHECK:STDOUT: %F.call = call i32 @F(), !dbg !12
// CHECK:STDOUT: %F.call = call i32 @_CF.Main(), !dbg !12
// CHECK:STDOUT: br label %if.expr.result, !dbg !11
// CHECK:STDOUT:
// CHECK:STDOUT: if.expr.else: ; preds = %entry
// CHECK:STDOUT: %G.call = call i32 @G(), !dbg !13
// CHECK:STDOUT: %G.call = call i32 @_CG.Main(), !dbg !13
// CHECK:STDOUT: br label %if.expr.result, !dbg !11
// CHECK:STDOUT:
// CHECK:STDOUT: if.expr.result: ; preds = %if.expr.else, %if.expr.then
@@ -52,13 +52,13 @@ fn Select(b: bool) -> i32 {
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
// CHECK:STDOUT: !3 = !DIFile(filename: "basic.carbon", directory: "")
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "F", linkageName: "F", scope: null, file: !3, line: 11, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "F", linkageName: "_CF.Main", scope: null, file: !3, line: 11, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
// CHECK:STDOUT: !6 = !{}
// CHECK:STDOUT: !7 = !DILocation(line: 11, column: 17, scope: !4)
// CHECK:STDOUT: !8 = distinct !DISubprogram(name: "G", linkageName: "G", scope: null, file: !3, line: 12, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !8 = distinct !DISubprogram(name: "G", linkageName: "_CG.Main", scope: null, file: !3, line: 12, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !9 = !DILocation(line: 12, column: 17, scope: !8)
// CHECK:STDOUT: !10 = distinct !DISubprogram(name: "Select", linkageName: "Select", scope: null, file: !3, line: 14, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !10 = distinct !DISubprogram(name: "Select", linkageName: "_CSelect.Main", scope: null, file: !3, line: 14, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !11 = !DILocation(line: 15, column: 10, scope: !10)
// CHECK:STDOUT: !12 = !DILocation(line: 15, column: 20, scope: !10)
// CHECK:STDOUT: !13 = !DILocation(line: 15, column: 29, scope: !10)
toolchain/lower/testdata/if_expr/empty_block.carbon
Vendored
+2 -2
View File
@@ -15,7 +15,7 @@ fn Select(b: bool, c: bool, d: bool) -> i32 {
// CHECK:STDOUT: ; ModuleID = 'empty_block.carbon'
// CHECK:STDOUT: source_filename = "empty_block.carbon"
// CHECK:STDOUT:
// CHECK:STDOUT: define i32 @Select(i1 %b, i1 %c, i1 %d) !dbg !4 {
// CHECK:STDOUT: define i32 @_CSelect.Main(i1 %b, i1 %c, i1 %d) !dbg !4 {
// CHECK:STDOUT: entry:
// CHECK:STDOUT: br i1 %b, label %if.expr.then.loc12_10, label %if.expr.else.loc12_10, !dbg !7
// CHECK:STDOUT:
@@ -57,7 +57,7 @@ fn Select(b: bool, c: bool, d: bool) -> i32 {
// CHECK:STDOUT: !1 = !{i32 2, !"Debug Info Version", i32 3}
// CHECK:STDOUT: !2 = distinct !DICompileUnit(language: DW_LANG_C, file: !3, producer: "carbon", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug)
// CHECK:STDOUT: !3 = !DIFile(filename: "empty_block.carbon", directory: "")
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "Select", linkageName: "Select", scope: null, file: !3, line: 11, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !4 = distinct !DISubprogram(name: "Select", linkageName: "_CSelect.Main", scope: null, file: !3, line: 11, type: !5, spFlags: DISPFlagDefinition, unit: !2)
// CHECK:STDOUT: !5 = !DISubroutineType(types: !6)
// CHECK:STDOUT: !6 = !{}
// CHECK:STDOUT: !7 = !DILocation(line: 12, column: 10, scope: !4)