carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove most of the metaprogramming in node.h in favor of listing all the members in the typed node structs. (#3310)

Browse Source 
Split `node.h` into separate files for ID types (`id.h`) and for typed
nodes (`typed_nodes.h`). The per-node-kind data is now specified as part
of declaring the typed nodes, and is removed from the node kinds
x-macros, which now simply enumerate the node kinds.
This commit is contained in:
Richard Smith
2023-10-20 20:26:10 +00:00
committed by GitHub
parent e54deee525
commit a46e7dd967
31 changed files with 1240 additions and 957 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/file_context.cpp
+3 -3
View File
@@ -238,9 +238,9 @@ auto FileContext::BuildType(SemIR::NodeId node_id) -> llvm::Type* {
auto field = semantics_ir_->GetNodeAs<SemIR::StructTypeField>(field_id);
// TODO: Handle recursive types. The restriction for builtins prevents
// recursion while still letting them cache.
CARBON_CHECK(field.type_id.index < SemIR::BuiltinKind::ValidCount)
<< field.type_id;
subtypes.push_back(GetType(field.type_id));
CARBON_CHECK(field.field_type_id.index < SemIR::BuiltinKind::ValidCount)
<< field.field_type_id;
subtypes.push_back(GetType(field.field_type_id));
}
return llvm::StructType::get(*llvm_context_, subtypes);
}