carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 06:21:04 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

[NFC] In DeclNameStack::AddName(), use NameScope::AddRequired() instead of duplicating its logic (#4610)

Browse Source 
This is a pure code deduplication change.
This commit is contained in:
Boaz Brickner
2024-12-02 20:06:01 +00:00
committed by GitHub
parent 63ff0cca1a
commit a297eef2d5
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/decl_name_stack.cpp
+3 -14
View File
@@ -154,20 +154,9 @@ auto DeclNameStack::AddName(NameContext name_context, SemIR::InstId target_id,
context_->AddExport(target_id);
}
auto add_scope = [&] {
int index = name_scope.names.size();
name_scope.names.push_back(
{.name_id = name_context.unresolved_name_id,
.inst_id = target_id,
.access_kind = access_kind});
return index;
};
auto result = name_scope.name_map.Insert(
name_context.unresolved_name_id, add_scope);
CARBON_CHECK(
result.is_inserted(),
"Duplicate names should have been resolved previously: {0} in {1}",
name_context.unresolved_name_id, name_context.parent_scope_id);
name_scope.AddRequired({.name_id = name_context.unresolved_name_id,
.inst_id = target_id,
.access_kind = access_kind});
}
break;