carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 15:01:03 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Improve source locations for some diagnostics. (#3644)

Browse Source
This commit is contained in:
Richard Smith
2024-01-24 03:37:00 +00:00
committed by GitHub
parent 2a44cedb8f
commit a1f1c7438f
5 changed files with 24 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/handle_array.cpp
+5 -4
View File
@@ -31,7 +31,8 @@ auto HandleArrayExpr(Context& context, Parse::ArrayExprId parse_node) -> bool {
auto bound_inst_id = context.node_stack().PopExpr();
context.node_stack()
.PopAndDiscardSoloParseNode<Parse::NodeKind::ArrayExprSemi>();
auto element_type_inst_id = context.node_stack().PopExpr();
auto [element_type_node_id, element_type_inst_id] =
context.node_stack().PopExprWithParseNode();
// The array bound must be a constant.
//
@@ -47,9 +48,9 @@ auto HandleArrayExpr(Context& context, Parse::ArrayExprId parse_node) -> bool {
}
context.AddInstAndPush(
{parse_node, SemIR::ArrayType{
SemIR::TypeId::TypeType, bound_inst_id,
ExprAsType(context, parse_node, element_type_inst_id)}});
{parse_node, SemIR::ArrayType{SemIR::TypeId::TypeType, bound_inst_id,
ExprAsType(context, element_type_node_id,
element_type_inst_id)}});
return true;
}