carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove excess use of auto on initializers (auto x = Y(z) -> Y x(z)) (#4239)

Browse Source
This commit is contained in:
David Blaikie
2024-08-22 20:29:35 +00:00
committed by GitHub
parent 1e1034ee81
commit a17480133f
9 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/subst.cpp
+7 -7
View File
@@ -63,12 +63,12 @@ static auto PushOperand(Context& context, Worklist& worklist,
SemIR::IdKind kind, int32_t arg) -> void {
switch (kind) {
case SemIR::IdKind::For<SemIR::InstId>:
if (auto inst_id = SemIR::InstId(arg); inst_id.is_valid()) {
if (SemIR::InstId inst_id(arg); inst_id.is_valid()) {
worklist.Push(inst_id);
}
break;
case SemIR::IdKind::For<SemIR::TypeId>:
if (auto type_id = SemIR::TypeId(arg); type_id.is_valid()) {
if (SemIR::TypeId type_id(arg); type_id.is_valid()) {
worklist.Push(context.types().GetInstId(type_id));
}
break;
@@ -111,21 +111,21 @@ static auto PopOperand(Context& context, Worklist& worklist, SemIR::IdKind kind,
int32_t arg) -> int32_t {
switch (kind) {
case SemIR::IdKind::For<SemIR::InstId>: {
auto inst_id = SemIR::InstId(arg);
SemIR::InstId inst_id(arg);
if (!inst_id.is_valid()) {
return arg;
}
return worklist.Pop().index;
}
case SemIR::IdKind::For<SemIR::TypeId>: {
auto type_id = SemIR::TypeId(arg);
SemIR::TypeId type_id(arg);
if (!type_id.is_valid()) {
return arg;
}
return context.GetTypeIdForTypeInst(worklist.Pop()).index;
}
case SemIR::IdKind::For<SemIR::InstBlockId>: {
auto old_inst_block_id = SemIR::InstBlockId(arg);
SemIR::InstBlockId old_inst_block_id(arg);
auto size = context.inst_blocks().Get(old_inst_block_id).size();
SemIR::CopyOnWriteInstBlock new_inst_block(context.sem_ir(),
old_inst_block_id);
@@ -135,7 +135,7 @@ static auto PopOperand(Context& context, Worklist& worklist, SemIR::IdKind kind,
return new_inst_block.GetCanonical().index;
}
case SemIR::IdKind::For<SemIR::TypeBlockId>: {
auto old_type_block_id = SemIR::TypeBlockId(arg);
SemIR::TypeBlockId old_type_block_id(arg);
auto size = context.type_blocks().Get(old_type_block_id).size();
SemIR::CopyOnWriteTypeBlock new_type_block(context.sem_ir(),
old_type_block_id);
@@ -146,7 +146,7 @@ static auto PopOperand(Context& context, Worklist& worklist, SemIR::IdKind kind,
return new_type_block.GetCanonical().index;
}
case SemIR::IdKind::For<SemIR::SpecificId>: {
auto specific_id = SemIR::SpecificId(arg);
SemIR::SpecificId specific_id(arg);
if (!specific_id.is_valid()) {
return arg;
}