carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Don't take a NodeId argument for insts that have no parse node. (#3623)

Browse Source 
This is low impact because we typically support a parse node, but I was
hoping to reduce ambiguity in the cases that don't.
This commit is contained in:
Jon Ross-Perkins
2024-01-19 19:59:19 +00:00
committed by GitHub
parent 816a48ca45
commit 9be99cad4c
3 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/import.cpp
+1 -2
View File
@@ -201,8 +201,7 @@ auto Import(Context& context, SemIR::TypeId namespace_type_id,
} else {
// Leave a placeholder that the inst comes from the other IR.
auto target_id = context.AddPlaceholderInst(
{Parse::NodeId::Invalid,
SemIR::LazyImportRef{.ir_id = ir_id, .inst_id = import_inst_id}});
{SemIR::LazyImportRef{.ir_id = ir_id, .inst_id = import_inst_id}});
// TODO: When importing from other packages, the scope's names should
// be changed to allow for ambiguous names. When importing from the
// current package, as is currently being done, we should issue a