From 9a9ccd8b7d43f202541ac5f9a4450b5c7aa379c5 Mon Sep 17 00:00:00 2001
From: Jon Meow <46229924+jonmeow@users.noreply.github.com>
Date: Thu, 12 Aug 2021 09:53:04 -0700
Subject: [PATCH] Exclude tab in string literals (#734)

Noticed this while working on #732, seemed easiest to split changes though.
---
 executable_semantics/syntax/lexer.lpp             | 2 +-
 executable_semantics/test_list.bzl                | 1 +
 executable_semantics/testdata/string_fail6.carbon | 8 ++++++++
 executable_semantics/testdata/string_fail6.golden | 2 ++
 4 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 executable_semantics/testdata/string_fail6.carbon
 create mode 100644 executable_semantics/testdata/string_fail6.golden

diff --git a/executable_semantics/syntax/lexer.lpp b/executable_semantics/syntax/lexer.lpp
index c302d46859ac..e438bd16b9a7 100644
--- a/executable_semantics/syntax/lexer.lpp
+++ b/executable_semantics/syntax/lexer.lpp
@@ -65,7 +65,7 @@ UNDERSCORE        "_"
 identifier    [A-Za-z_][A-Za-z0-9_]*
 sized_type_literal [iuf][1-9][0-9]*
 integer_literal   [0-9]+
-string_literal    \"([^\\\"\n]|\\.)*\"
+string_literal    \"([^\\\"\n\t]|\\.)*\"
 horizontal_whitespace [ \t\r]
 whitespace [ \t\r\n]
 operand_start [(A-Za-z0-9_"]
diff --git a/executable_semantics/test_list.bzl b/executable_semantics/test_list.bzl
index 6feff1268ca0..c6cc0e3e97fa 100644
--- a/executable_semantics/test_list.bzl
+++ b/executable_semantics/test_list.bzl
@@ -83,6 +83,7 @@ TEST_LIST = [
     "string_fail3",
     "string_fail4",
     "string_fail5",
+    "string_fail6",
     "struct1",
     "struct2",
     "struct3",
diff --git a/executable_semantics/testdata/string_fail6.carbon b/executable_semantics/testdata/string_fail6.carbon
new file mode 100644
index 000000000000..6e37042affa0
--- /dev/null
+++ b/executable_semantics/testdata/string_fail6.carbon
@@ -0,0 +1,8 @@
+// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
+// Exceptions. See /LICENSE for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+fn main() -> i32 {
+  Print("new	line");
+  return 0;
+}
diff --git a/executable_semantics/testdata/string_fail6.golden b/executable_semantics/testdata/string_fail6.golden
new file mode 100644
index 000000000000..c2abd374a6be
--- /dev/null
+++ b/executable_semantics/testdata/string_fail6.golden
@@ -0,0 +1,2 @@
+COMPILATION ERROR: 6: invalid character '\x22' in source file.
+EXIT CODE: 255