carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 06:54:44 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename check handlers to HandleParseNode overloads. (#4121)

Browse Source 
This is for consistency with #4120. Similar to that, we can use
overloads on the typed NodeId rather than individually named handlers.
There isn't the same caller benefit here though, since the calls from
check.cpp are already boilerplate.
This commit is contained in:
Jon Ross-Perkins
2024-07-12 22:38:06 +00:00
committed by GitHub
parent bb8417c810
commit 99696b9812
34 changed files with 290 additions and 339 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/handle_binding_pattern.cpp
+5 -6
View File
@@ -191,18 +191,17 @@ static auto HandleAnyBindingPattern(Context& context, Parse::NodeId node_id,
return true;
}
auto HandleBindingPattern(Context& context, Parse::BindingPatternId node_id)
auto HandleParseNode(Context& context, Parse::BindingPatternId node_id)
-> bool {
return HandleAnyBindingPattern(context, node_id, /*is_generic=*/false);
}
auto HandleCompileTimeBindingPattern(Context& context,
Parse::CompileTimeBindingPatternId node_id)
-> bool {
auto HandleParseNode(Context& context,
Parse::CompileTimeBindingPatternId node_id) -> bool {
return HandleAnyBindingPattern(context, node_id, /*is_generic=*/true);
}
auto HandleAddr(Context& context, Parse::AddrId node_id) -> bool {
auto HandleParseNode(Context& context, Parse::AddrId node_id) -> bool {
auto self_param_id = context.node_stack().PopPattern();
if (auto self_param =
context.insts().TryGetAs<SemIR::AnyBindName>(self_param_id);
@@ -222,7 +221,7 @@ auto HandleAddr(Context& context, Parse::AddrId node_id) -> bool {
return true;
}
auto HandleTemplate(Context& context, Parse::TemplateId node_id) -> bool {
auto HandleParseNode(Context& context, Parse::TemplateId node_id) -> bool {
return context.TODO(node_id, "HandleTemplate");
}