carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 21:21:19 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Implement basic bool and int formatting for diagnostics (#4411)

Browse Source 
Note, this supports plurals, but doesn't apply it anywhere. I'm mainly
doing that to demonstrate the approach regarding syntax. See
format_providers.h for details.
This commit is contained in:
Jon Ross-Perkins
2024-10-16 22:46:15 +00:00
committed by GitHub
parent a5ba0eed6a
commit 96964ee534
13 changed files with 416 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/diagnostics/format_providers_test.cpp
+86
View File
@@ -0,0 +1,86 @@
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/diagnostics/format_providers.h"
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include "llvm/Support/FormatVariadic.h"
namespace Carbon {
namespace {
using ::testing::Eq;
TEST(BoolAsSelect, Cases) {
constexpr char Format[] = "{0:a|b}";
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(true)).str(), Eq("a"));
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(false)).str(), Eq("b"));
}
TEST(BoolAsSelect, CasesWithNormalFormat) {
constexpr char Format[] = "{0} {0:a|b}";
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(true)).str(), Eq("true a"));
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(false)).str(), Eq("false b"));
}
TEST(BoolAsSelect, Spaces) {
constexpr char Format[] = "{0: a | b }";
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(true)).str(), Eq("a "));
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(false)).str(), Eq(" b"));
}
TEST(BoolAsSelect, QuotedSpaces) {
constexpr char Format[] = "{0:' a | b '}";
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(true)).str(), Eq(" a "));
EXPECT_THAT(llvm::formatv(Format, BoolAsSelect(false)).str(), Eq(" b "));
}
TEST(IntAsSelect, OnlyDefault) {
constexpr char Format[] = "{0::default}";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq("default"));
}
TEST(IntAsSelect, OneEquals) {
constexpr char Format[] = "{0:=0:zero}";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq("zero"));
}
TEST(IntAsSelect, TwoEquals) {
constexpr char Format[] = "{0:=0:zero|=1:one}";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq("zero"));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(1)).str(), Eq("one"));
}
TEST(IntAsSelect, TwoEqualsAndDefault) {
constexpr char Format[] = "{0:=0:zero|=1:one|:default}";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq("zero"));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(1)).str(), Eq("one"));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(2)).str(), Eq("default"));
}
TEST(IntAsSelect, Spaces) {
constexpr char Format[] = "{0:=0: zero |=1: one |: default }";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq(" zero "));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(1)).str(), Eq(" one "));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(2)).str(), Eq(" default"));
}
TEST(IntAsSelect, QuotedSpaces) {
constexpr char Format[] = "{0:'=0: zero |=1: one |: default '}";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq(" zero "));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(1)).str(), Eq(" one "));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(2)).str(), Eq(" default "));
}
TEST(IntAsSelect, PluralExample) {
constexpr char Format[] = "{0} argument{0:=1:|:s}";
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(0)).str(), Eq("0 arguments"));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(1)).str(), Eq("1 argument"));
EXPECT_THAT(llvm::formatv(Format, IntAsSelect(2)).str(), Eq("2 arguments"));
}
} // namespace
} // namespace Carbon