carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-27 22:02:33 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Make function definitions allocate the body more lazily. (#2557)

Browse Source 
Lazy allocation means that we can use a single node block for _all_ empty node blocks. The change in timing for when the definition node is emitted shouldn't affect semantic correctness; the signature is already present for recursive calls.
This commit is contained in:
Jon Ross-Perkins
2023-01-27 11:46:12 -08:00
committed by GitHub
parent 2ffbe72384
commit 94cbb9d917
23 changed files with 78 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_node_block_stack.cpp
-12
View File
@@ -16,18 +16,6 @@ auto SemanticsNodeBlockStack::Push() -> void {
stack_.push_back(SemanticsNodeBlockId::Invalid);
}
auto SemanticsNodeBlockStack::PushWithUnconditionalAlloc()
-> SemanticsNodeBlockId {
SemanticsNodeBlockId block_id(node_blocks_->size());
CARBON_VLOG() << "NodeBlock Push " << stack_.size() << ": " << block_id
<< "\n";
CARBON_CHECK(stack_.size() < (1 << 20))
<< "Excessive stack size: likely infinite loop";
node_blocks_->resize(block_id.index + 1);
stack_.push_back(block_id);
return block_id;
}
auto SemanticsNodeBlockStack::PeekForAdd() -> SemanticsNodeBlockId {
auto& back = stack_.back();
if (!back.is_valid()) {