carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Use the constant value unconditionally in deduce diagnostic (#5034)

Browse Source 
When finding the binding entity name, always go through the binding
instruction's constant value to get a canonical instruction which will
always have an entity name attached to it.

Currently the only instructions in this position without an entity name
are ImportRefLoaded. But other indirect instructions may exist in the
future, which evaluate to an AnyBindName but are not themselves one. So
this makes the code more robust to change in the future.
This commit is contained in:
Dana Jansens
2025-02-27 17:06:02 +00:00
committed by GitHub
parent f97f1a3e11
commit 92e635c2f0
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/deduce.cpp
+4 -5
View File
@@ -511,11 +511,10 @@ auto DeductionContext::Deduce() -> bool {
static auto GetEntityNameForGenericBinding(Context& context,
SemIR::InstId binding_id)
-> SemIR::NameId {
// If `binding_id` is imported, it may not have an entity name. Get a
// canonical local instruction from its constant value which does.
if (context.insts().Is<SemIR::ImportRefLoaded>(binding_id)) {
binding_id = context.constant_values().GetConstantInstId(binding_id);
}
// If `binding_id` is imported (or referenced indirectly perhaps in the
// future), it may not have an entity name. Get a canonical local instruction
// from its constant value which does.
binding_id = context.constant_values().GetConstantInstId(binding_id);
if (auto bind_name =
context.insts().TryGetAs<SemIR::AnyBindName>(binding_id)) {