carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 17:13:16 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Model the return slot as an output parameter (#4432)

Browse Source 
Also fix `Param` insts to have meaningful names in pretty-printing, to
help clarify relationship with return slot.
This commit is contained in:
Geoff Romer
2024-10-23 16:53:34 +00:00
committed by GitHub
parent 5038218cea
commit 9266f867f9
463 changed files with 7401 additions and 4939 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/sem_ir/function.cpp
+5 -2
View File
@@ -95,6 +95,9 @@ auto Function::GetNameFromPatternId(const File& sem_ir, InstId pattern_id)
inst_id = param_pattern_inst.subpattern_id;
inst = sem_ir.insts().Get(inst_id);
if (inst.Is<ReturnSlotPattern>()) {
return SemIR::NameId::ReturnSlot;
}
auto binding_pattern = inst.As<AnyBindingPattern>();
return sem_ir.entity_names().Get(binding_pattern.entity_name_id).name_id;
}
@@ -115,11 +118,11 @@ auto Function::GetParamFromParamRefId(const File& sem_ir, InstId param_ref_id)
auto Function::GetDeclaredReturnType(const File& file,
SpecificId specific_id) const -> TypeId {
if (!return_storage_id.is_valid()) {
if (!return_slot_id.is_valid()) {
return TypeId::Invalid;
}
return GetTypeInSpecific(file, specific_id,
file.insts().Get(return_storage_id).type_id());
file.insts().Get(return_slot_id).type_id());
}
} // namespace Carbon::SemIR