carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Model the return slot as an output parameter (#4432)

Browse Source 
Also fix `Param` insts to have meaningful names in pretty-printing, to
help clarify relationship with return slot.
This commit is contained in:
Geoff Romer
2024-10-23 16:53:34 +00:00
committed by GitHub
parent 5038218cea
commit 9266f867f9
463 changed files with 7401 additions and 4939 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/file_context.cpp
+3 -3
View File
@@ -228,7 +228,7 @@ auto FileContext::BuildFunctionDecl(SemIR::FunctionId function_id,
param_inst_ids.reserve(max_llvm_params);
if (return_info.has_return_slot()) {
param_types.push_back(return_type->getPointerTo());
param_inst_ids.push_back(function.return_storage_id);
param_inst_ids.push_back(function.return_slot_id);
}
for (auto param_pattern_id : llvm::concat<const SemIR::InstId>(
implicit_param_patterns, param_patterns)) {
@@ -280,7 +280,7 @@ auto FileContext::BuildFunctionDecl(SemIR::FunctionId function_id,
for (auto [inst_id, arg] :
llvm::zip_equal(param_inst_ids, llvm_function->args())) {
auto name_id = SemIR::NameId::Invalid;
if (inst_id == function.return_storage_id) {
if (inst_id == function.return_slot_id) {
name_id = SemIR::NameId::ReturnSlot;
arg.addAttr(
llvm::Attribute::getWithStructRetType(llvm_context(), return_type));
@@ -326,7 +326,7 @@ auto FileContext::BuildFunctionDefinition(SemIR::FunctionId function_id)
int param_index = 0;
if (SemIR::ReturnTypeInfo::ForFunction(sem_ir(), function, specific_id)
.has_return_slot()) {
function_lowering.SetLocal(function.return_storage_id,
function_lowering.SetLocal(function.return_slot_id,
llvm_function->getArg(param_index));
++param_index;
}