carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Rename Parse::State to Parse::StateKind (#5249)

Browse Source 
Also renames variables of that type to match. A follow-up PR will rename
`Parse::StateStackEntry` to `Parse::State`. This is more consistent with
the naming of similar enums elsewhere in the toolchain, and with the
prevailing practice of using `state` rather than e.g. `entry` as the
name of a `StateStackEntry`.

See also discussion
[here](https://discord.com/channels/655572317891461132/963846118964350976/1326280585592700990)
This commit is contained in:
Geoff Romer
2025-04-05 04:25:00 +00:00
committed by GitHub
parent 2fa2425ef5
commit 8c113c1241
36 changed files with 347 additions and 328 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/parse/handle_alias.cpp
+4 -4
View File
@@ -14,8 +14,8 @@ namespace Carbon::Parse {
auto HandleAlias(Context& context) -> void {
auto state = context.PopState();
context.PushState(state, State::AliasAfterName);
context.PushState(State::DeclNameAndParams, state.token);
context.PushState(state, StateKind::AliasAfterName);
context.PushState(StateKind::DeclNameAndParams, state.token);
}
auto HandleAliasAfterName(Context& context) -> void {
@@ -29,8 +29,8 @@ auto HandleAliasAfterName(Context& context) -> void {
if (auto equal = context.ConsumeIf(Lex::TokenKind::Equal)) {
context.AddLeafNode(NodeKind::AliasInitializer, *equal);
context.PushState(state, State::AliasFinish);
context.PushState(State::Expr);
context.PushState(state, StateKind::AliasFinish);
context.PushState(StateKind::Expr);
} else {
CARBON_DIAGNOSTIC(ExpectedAliasInitializer, Error,
"`alias` requires a `=` for the source");