mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-28 22:02:37 +01:00
Replace :! binding syntax with phase keywords and contextual defaults (#7479)
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
This commit is contained in:
@@ -13,10 +13,10 @@ static auto HandlePatternListElement(Context& context, StateKind pattern_state,
|
||||
auto state = context.PopState();
|
||||
|
||||
context.PushStateForPattern(finish_state_kind, state.in_var_pattern,
|
||||
state.in_unused_pattern,
|
||||
state.in_unused_pattern, state.binding_context,
|
||||
state.ambient_precedence);
|
||||
context.PushStateForPattern(pattern_state, state.in_var_pattern,
|
||||
state.in_unused_pattern,
|
||||
state.in_unused_pattern, state.binding_context,
|
||||
state.ambient_precedence);
|
||||
}
|
||||
|
||||
@@ -60,7 +60,7 @@ static auto HandlePatternListElementFinish(Context& context,
|
||||
|
||||
if (list_token_kind == Context::ListTokenKind::Comma) {
|
||||
context.PushStateForPattern(param_state_kind, state.in_var_pattern,
|
||||
state.in_unused_pattern,
|
||||
state.in_unused_pattern, state.binding_context,
|
||||
state.ambient_precedence);
|
||||
}
|
||||
}
|
||||
@@ -93,12 +93,12 @@ static auto HandlePatternList(Context& context, NodeKind node_kind,
|
||||
|
||||
context.PushStateForPattern(
|
||||
empty ? finish_state_empty : finish_state_nonempty, state.in_var_pattern,
|
||||
state.in_unused_pattern, state.ambient_precedence);
|
||||
state.in_unused_pattern, state.binding_context, state.ambient_precedence);
|
||||
context.AddLeafNode(node_kind, open_token);
|
||||
|
||||
if (!empty) {
|
||||
context.PushStateForPattern(param_state, state.in_var_pattern,
|
||||
state.in_unused_pattern,
|
||||
state.in_unused_pattern, state.binding_context,
|
||||
PrecedenceGroup::ForTopLevelExpr());
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user