Replace :! binding syntax with phase keywords and contextual defaults (#7479)

Implement the toolchain side of proposal #7254, removing the `:!`
binding
syntax for generic and template parameters in favor of the keywords
`generic`,
`template`, and `runtime` plus contextual defaults for phase.

For valid programs this is semantics-preserving: each binding resolves
to the
same phase, and produces the same SemIR, as it did under `:!`/`:`. The
parser
derives a binding's phase from its syntactic context plus any explicit
phase
keyword; new diagnostics and error recovery for misused keywords are
described
below.

Implementation details for each component:

- Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual
parse-node
  budget onto `:`, and add the `generic` and `runtime` keywords.
- Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or
`CompileTimeEntityParam`) from declaration introducers down through
parameter
lists to each binding pattern, using a one-token lookahead to
distinguish a
name-qualifier parameter list from a declaration's own final list.
Parameters
of a compile-time entity (`class`, `interface`, `constraint`, `choice`,
`alias`, `export`, `namespace`) and deduced `[]` parameters default to
checked
generic; explicit function parameters and local bindings default to
runtime.
`HandleBindingPattern` resolves the phase from that context plus the
keyword: a
`generic` keyword needs no node of its own (the phase is carried by the
  binding's node kind), while a `runtime` keyword is preserved as a
`RuntimeBindingName` node so `check` can name it in a diagnostic. A
phase
keyword that is merely redundant with the contextual default is
diagnosed
  here, without invalidating the parse tree.
- Check: a phase keyword that is invalid for its context (for example
`runtime`
on a checked-generic parameter) is diagnosed here, and recovers by
building an
error binding that still introduces the name so that later uses of it do
not
  produce cascading errors.

The removed `:!` syntax is now rejected as an ordinary parse error.

The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is
left for a
separate change.

Assisted-by: Claude Code
This commit is contained in:
Chandler Carruth
2026-07-11 01:22:44 +00:00
committed by GitHub
parent bf106c3b4b
commit 8be274cf60
482 changed files with 16917 additions and 16226 deletions
+38 -4
View File
@@ -30,6 +30,20 @@ enum class Lookahead : int32_t {
NextToken = 1,
};
// The syntactic context of a binding pattern, which determines its default
// phase when no explicit `generic`/`template`/`runtime` keyword is present.
enum class BindingContext : uint8_t {
// An explicit `()` parameter of a function, or a local binding
// (`let`/`var`/`for`/`match`). Runtime by default.
ExplicitParam,
// A deduced `[]` parameter, whether of a function, a compile-time entity, or
// an `impl`'s `forall`. Checked generic by default.
DeducedParam,
// An explicit `()` parameter of a compile-time entity (such as a `class`), or
// of a parameterized name qualifier. Checked generic by default.
CompileTimeEntityParam,
};
// Context and shared functionality for parser handlers. See state.def for state
// documentation.
class Context {
@@ -102,6 +116,12 @@ class Context {
// could help catch errors.
bool in_unused_pattern : 1 = false;
// The binding context governing this state, used to pick the default phase
// of its bindings. Meaningful for pattern states, and for the
// declaration-name states that carry an enclosing declaration's default
// down to its parameter lists.
BindingContext binding_context : 2 = BindingContext::ExplicitParam;
// Precedence information used by expression states in order to determine
// operator precedence. The ambient_precedence deals with how the expression
// should interact with outside context, while the lhs_precedence is
@@ -119,7 +139,7 @@ class Context {
// We expect State to fit into 12 bytes:
// state = 1 byte
// has_error, in_var_pattern, and in_unused_pattern = 1 byte
// has_error, in_var_pattern, in_unused_pattern, binding_context = 1 byte
// ambient_precedence = 1 byte
// lhs_precedence = 1 byte
// token = 4 bytes
@@ -318,6 +338,17 @@ class Context {
PushState({.kind = kind, .token = token, .subtree_start = tree_->size()});
}
// Pushes a new state with a specific token and binding context. Used when
// starting a parameter list whose bindings have a non-default phase, or when
// carrying a declaration's binding context across a qualified name.
auto PushState(StateKind kind, Lex::TokenIndex token,
BindingContext binding_context) -> void {
PushState({.kind = kind,
.binding_context = binding_context,
.token = token,
.subtree_start = tree_->size()});
}
// Pushes a new expression state with specific precedence.
auto PushStateForExpr(PrecedenceGroup ambient_precedence) -> void {
PushState({.kind = StateKind::Expr,
@@ -338,13 +369,16 @@ class Context {
// Pushes a new state for handling a pattern. `in_var_pattern` and
// `in_unused_pattern` indicate whether that pattern is nested inside a `var`
// or `unused` pattern.
// or `unused` pattern. `binding_context` is the binding context that
// determines the default phase of bindings in this pattern.
auto PushStateForPattern(StateKind kind, bool in_var_pattern,
bool in_unused_pattern, PrecedenceGroup precedence)
-> void {
bool in_unused_pattern,
BindingContext binding_context,
PrecedenceGroup precedence) -> void {
PushState({.kind = kind,
.in_var_pattern = in_var_pattern,
.in_unused_pattern = in_unused_pattern,
.binding_context = binding_context,
.ambient_precedence = precedence,
.token = *position_,
.subtree_start = tree_->size()});