Replace :! binding syntax with phase keywords and contextual defaults (#7479)

Implement the toolchain side of proposal #7254, removing the `:!`
binding
syntax for generic and template parameters in favor of the keywords
`generic`,
`template`, and `runtime` plus contextual defaults for phase.

For valid programs this is semantics-preserving: each binding resolves
to the
same phase, and produces the same SemIR, as it did under `:!`/`:`. The
parser
derives a binding's phase from its syntactic context plus any explicit
phase
keyword; new diagnostics and error recovery for misused keywords are
described
below.

Implementation details for each component:

- Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual
parse-node
  budget onto `:`, and add the `generic` and `runtime` keywords.
- Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or
`CompileTimeEntityParam`) from declaration introducers down through
parameter
lists to each binding pattern, using a one-token lookahead to
distinguish a
name-qualifier parameter list from a declaration's own final list.
Parameters
of a compile-time entity (`class`, `interface`, `constraint`, `choice`,
`alias`, `export`, `namespace`) and deduced `[]` parameters default to
checked
generic; explicit function parameters and local bindings default to
runtime.
`HandleBindingPattern` resolves the phase from that context plus the
keyword: a
`generic` keyword needs no node of its own (the phase is carried by the
  binding's node kind), while a `runtime` keyword is preserved as a
`RuntimeBindingName` node so `check` can name it in a diagnostic. A
phase
keyword that is merely redundant with the contextual default is
diagnosed
  here, without invalidating the parse tree.
- Check: a phase keyword that is invalid for its context (for example
`runtime`
on a checked-generic parameter) is diagnosed here, and recovers by
building an
error binding that still introduces the name so that later uses of it do
not
  produce cascading errors.

The removed `:!` syntax is now rejected as an ordinary parse error.

The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is
left for a
separate change.

Assisted-by: Claude Code
This commit is contained in:
Chandler Carruth
2026-07-11 01:22:44 +00:00
committed by GitHub
parent bf106c3b4b
commit 8be274cf60
482 changed files with 16917 additions and 16226 deletions
+3 -3
View File
@@ -40,7 +40,7 @@ class A {}
class B {}
class C {}
interface I(T:! type) {
interface I(T: type) {
fn F(self) -> T;
}
@@ -57,7 +57,7 @@ fn F1(x: C, y: C) {
var unused b: B = y.(I(B).F)();
}
fn F2[T:! I(A), U:! I(B)](x: T, y: U) {
fn F2[T: I(A), U: I(B)](x: T, y: U) {
var unused a: A = x.F();
var unused b: B = y.F();
}
@@ -69,7 +69,7 @@ library "[[@TEST_NAME]]";
class A {}
class B {}
class C(T:! type) {}
class C(T: type) {}
interface I {
fn F();
+3 -3
View File
@@ -16,7 +16,7 @@
// --- a.carbon
library "[[@TEST_NAME]]";
class C(T:! Core.Copy & Core.UnformedInit & Core.Destroy) {
class C(T: Core.Copy & Core.UnformedInit & Core.Destroy) {
fn GetC(unused self) -> T {
var value: T;
return value;
@@ -28,7 +28,7 @@ library "[[@TEST_NAME]]";
export import library "a";
interface I {
let T:! Core.Copy & Core.UnformedInit & Core.Destroy;
let T: Core.Copy & Core.UnformedInit & Core.Destroy;
fn GetI(self) -> C(T);
}
@@ -36,7 +36,7 @@ interface I {
library "[[@TEST_NAME]]";
export import library "b";
class D(U:! type) {
class D(U: type) {
impl as I where .T = U* {
fn GetI(unused self) -> C(U*) {
return {};
+4 -4
View File
@@ -16,18 +16,18 @@ library "[[@TEST_NAME]]";
interface J {}
class A(T:! type) {}
class A(T: type) {}
class B {}
impl forall [T:! type] A(T) as J {}
impl forall [T: type] A(T) as J {}
impl forall [T:! type where A(.Self) impls J] A(T) as Core.As(T*) {
impl forall [T: type where A(.Self) impls J] A(T) as Core.As(T*) {
fn Convert(self) -> T* {
return self as T*;
}
}
fn F[T:! type](x: A(T)) {
fn F[T: type](x: A(T)) {
x as T*;
}
+4 -4
View File
@@ -48,13 +48,13 @@ class B {
}
}
interface I(T:! type) {
interface I(T: type) {
fn F(self, x: B) -> A;
}
class C(U:! type) {}
class C(U: type) {}
impl forall [V:! type] C(V) as I(V) {
impl forall [V: type] C(V) as I(V) {
fn F(unused self, _: A) -> B { return {}; }
}
@@ -62,7 +62,7 @@ fn Call(c: C(()), b: B) -> A {
return c.(I(()).F)(b);
}
fn CallGeneric[T:! I(())](c: T, b: B) -> A {
fn CallGeneric[T: I(())](c: T, b: B) -> A {
return c.F(b);
}