carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-06 06:54:44 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove BinaryOperatorAdd (#3469)

Browse Source 
BinaryOperatorAdd had been added early on as a proof-of-concept for
toolchain design for parsing -> checking flow. However, it doesn't
reflect the interface direction for operators, and now other portions of
the toolchain demonstrate the relevant logic. Instead, it's just a bit
of an outlier versus other instructions which have evolved over time.
This commit is contained in:
Jon Ross-Perkins
2023-12-08 01:06:19 +00:00
committed by GitHub
parent 226b653e11
commit 8ace1dcb78
20 changed files with 232 additions and 230 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/if_expr/basic.carbon
Vendored
+31 -11
View File
@@ -5,11 +5,17 @@
// AUTOUPDATE
fn F(b: bool, n: i32, m: i32) -> i32 {
return if b then n + m else m + n;
var x: [i32; 1] = (0,);
return if b then x[m] else x[n];
}
// CHECK:STDOUT: --- basic.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %.loc8_17: type = ptr_type [i32; 1]
// CHECK:STDOUT: %.loc8_24: type = tuple_type (i32)
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace {.F = %F}
// CHECK:STDOUT: %F: <function> = fn_decl @F
@@ -17,23 +23,37 @@ fn F(b: bool, n: i32, m: i32) -> i32 {
// CHECK:STDOUT:
// CHECK:STDOUT: fn @F(%b: bool, %n: i32, %m: i32) -> i32 {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %.loc8_16: i32 = int_literal 1
// CHECK:STDOUT: %.loc8_17: type = array_type %.loc8_16, i32
// CHECK:STDOUT: %x.var: ref [i32; 1] = var x
// CHECK:STDOUT: %x: ref [i32; 1] = bind_name x, %x.var
// CHECK:STDOUT: %.loc8_22: i32 = int_literal 0
// CHECK:STDOUT: %.loc8_24.1: (i32,) = tuple_literal (%.loc8_22)
// CHECK:STDOUT: %.loc8_24.2: i32 = int_literal 0
// CHECK:STDOUT: %.loc8_24.3: ref i32 = array_index %x.var, %.loc8_24.2
// CHECK:STDOUT: %.loc8_24.4: init i32 = initialize_from %.loc8_22 to %.loc8_24.3
// CHECK:STDOUT: %.loc8_24.5: init [i32; 1] = array_init (%.loc8_24.4) to %x.var
// CHECK:STDOUT: %.loc8_24.6: init [i32; 1] = converted %.loc8_24.1, %.loc8_24.5
// CHECK:STDOUT: assign %x.var, %.loc8_24.6
// CHECK:STDOUT: %b.ref: bool = name_ref b, %b
// CHECK:STDOUT: if %b.ref br !if.expr.then else br !if.expr.else
// CHECK:STDOUT:
// CHECK:STDOUT: !if.expr.then:
// CHECK:STDOUT: %n.ref.loc8_20: i32 = name_ref n, %n
// CHECK:STDOUT: %m.ref.loc8_24: i32 = name_ref m, %m
// CHECK:STDOUT: %.loc8_22: i32 = add %n.ref.loc8_20, %m.ref.loc8_24
// CHECK:STDOUT: br !if.expr.result(%.loc8_22)
// CHECK:STDOUT: %x.ref.loc9_20: ref [i32; 1] = name_ref x, %x
// CHECK:STDOUT: %m.ref: i32 = name_ref m, %m
// CHECK:STDOUT: %.loc9_23.1: ref i32 = array_index %x.ref.loc9_20, %m.ref
// CHECK:STDOUT: %.loc9_23.2: i32 = bind_value %.loc9_23.1
// CHECK:STDOUT: br !if.expr.result(%.loc9_23.2)
// CHECK:STDOUT:
// CHECK:STDOUT: !if.expr.else:
// CHECK:STDOUT: %m.ref.loc8_31: i32 = name_ref m, %m
// CHECK:STDOUT: %n.ref.loc8_35: i32 = name_ref n, %n
// CHECK:STDOUT: %.loc8_33: i32 = add %m.ref.loc8_31, %n.ref.loc8_35
// CHECK:STDOUT: br !if.expr.result(%.loc8_33)
// CHECK:STDOUT: %x.ref.loc9_30: ref [i32; 1] = name_ref x, %x
// CHECK:STDOUT: %n.ref: i32 = name_ref n, %n
// CHECK:STDOUT: %.loc9_33.1: ref i32 = array_index %x.ref.loc9_30, %n.ref
// CHECK:STDOUT: %.loc9_33.2: i32 = bind_value %.loc9_33.1
// CHECK:STDOUT: br !if.expr.result(%.loc9_33.2)
// CHECK:STDOUT:
// CHECK:STDOUT: !if.expr.result:
// CHECK:STDOUT: %.loc8_10: i32 = block_arg !if.expr.result
// CHECK:STDOUT: return %.loc8_10
// CHECK:STDOUT: %.loc9_10: i32 = block_arg !if.expr.result
// CHECK:STDOUT: return %.loc9_10
// CHECK:STDOUT: }
// CHECK:STDOUT: