carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove BinaryOperatorAdd (#3469)

Browse Source 
BinaryOperatorAdd had been added early on as a proof-of-concept for
toolchain design for parsing -> checking flow. However, it doesn't
reflect the interface direction for operators, and now other portions of
the toolchain demonstrate the relevant logic. Instead, it's just a bit
of an outlier versus other instructions which have evolved over time.
This commit is contained in:
Jon Ross-Perkins
2023-12-08 01:06:19 +00:00
committed by GitHub
parent 226b653e11
commit 8ace1dcb78
20 changed files with 232 additions and 230 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/testdata/function/call/more_param_ir.carbon
Vendored
+23 -15
View File
@@ -4,17 +4,20 @@
//
// AUTOUPDATE
fn Foo(a: i32, b: i32, c: i32) {}
fn Foo(a: i32, b: i32) {}
fn Main() {
// Generates multiple IR instructions for the first two parameters.
Foo(1 + 2 + 3, 4 + 5, 6);
var x: (i32,) = (1,);
// Generates multiple IR instructions for the first parameter.
Foo(x[0], 6);
}
// CHECK:STDOUT: --- more_param_ir.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %.loc11: type = tuple_type ()
// CHECK:STDOUT: %.loc10_15.1: type = tuple_type (type)
// CHECK:STDOUT: %.loc10_15.2: type = tuple_type (i32)
// CHECK:STDOUT: %.loc12: type = tuple_type ()
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
@@ -23,24 +26,29 @@ fn Main() {
// CHECK:STDOUT: %Main: <function> = fn_decl @Main
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @Foo(%a: i32, %b: i32, %c: i32) {
// CHECK:STDOUT: fn @Foo(%a: i32, %b: i32) {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: return
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @Main() {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %.loc10_15.1: (type,) = tuple_literal (i32)
// CHECK:STDOUT: %.loc10_15.2: type = converted %.loc10_15.1, constants.%.loc10_15.2
// CHECK:STDOUT: %x.var: ref (i32,) = var x
// CHECK:STDOUT: %x: ref (i32,) = bind_name x, %x.var
// CHECK:STDOUT: %.loc10_20: i32 = int_literal 1
// CHECK:STDOUT: %.loc10_22.1: (i32,) = tuple_literal (%.loc10_20)
// CHECK:STDOUT: %.loc10_22.2: init (i32,) = tuple_init (%.loc10_20) to %x.var
// CHECK:STDOUT: %.loc10_22.3: init (i32,) = converted %.loc10_22.1, %.loc10_22.2
// CHECK:STDOUT: assign %x.var, %.loc10_22.3
// CHECK:STDOUT: %Foo.ref: <function> = name_ref Foo, file.%Foo
// CHECK:STDOUT: %.loc11_7: i32 = int_literal 1
// CHECK:STDOUT: %.loc11_11: i32 = int_literal 2
// CHECK:STDOUT: %.loc11_9: i32 = add %.loc11_7, %.loc11_11
// CHECK:STDOUT: %.loc11_15: i32 = int_literal 3
// CHECK:STDOUT: %.loc11_13: i32 = add %.loc11_9, %.loc11_15
// CHECK:STDOUT: %.loc11_18: i32 = int_literal 4
// CHECK:STDOUT: %.loc11_22: i32 = int_literal 5
// CHECK:STDOUT: %.loc11_20: i32 = add %.loc11_18, %.loc11_22
// CHECK:STDOUT: %.loc11_25: i32 = int_literal 6
// CHECK:STDOUT: %.loc11_6: init () = call %Foo.ref(%.loc11_13, %.loc11_20, %.loc11_25)
// CHECK:STDOUT: %x.ref: ref (i32,) = name_ref x, %x
// CHECK:STDOUT: %.loc12_9: i32 = int_literal 0
// CHECK:STDOUT: %.loc12_10.1: ref i32 = tuple_index %x.ref, %.loc12_9
// CHECK:STDOUT: %.loc12_13: i32 = int_literal 6
// CHECK:STDOUT: %.loc12_10.2: i32 = bind_value %.loc12_10.1
// CHECK:STDOUT: %.loc12_6: init () = call %Foo.ref(%.loc12_10.2, %.loc12_13)
// CHECK:STDOUT: return
// CHECK:STDOUT: }
// CHECK:STDOUT: