From 8aca184cdb4a97719f7ded9f849aaf67631fc7be Mon Sep 17 00:00:00 2001 From: Jon Ross-Perkins Date: Mon, 15 May 2023 13:58:20 -0700 Subject: [PATCH] Remove dependent issues trigger (#2815) Essentially, on #2814 I noticed that saying `#2811 depends` [word break] `on #2813` led to this trigger activating. This led to me asking whether anyone uses it, and responses were okay with it being removed. It's had [limited use](https://github.com/carbon-language/carbon-lang/pulls?q=is%3Apr+%22By+Dependent+Issues%22+), so this shouldn't be expected to affect workflows (unfortunately partly because dependent PRs aren't handled well by GitHub's review interface). Discussed [on Discord](https://discord.com/channels/655572317891461132/707150492370862090/1103721071221407835). Also minor edit to replace `-` with `_` in pre-commit filename ([style](https://github.com/carbon-language/carbon-lang/blob/trunk/docs/project/cpp_style_guide.md#file-names)). --- .github/workflows/dependent-issues.yaml | 32 ------------------- .../{pre-commit.yaml => pre_commit.yaml} | 0 2 files changed, 32 deletions(-) delete mode 100644 .github/workflows/dependent-issues.yaml rename .github/workflows/{pre-commit.yaml => pre_commit.yaml} (100%) diff --git a/.github/workflows/dependent-issues.yaml b/.github/workflows/dependent-issues.yaml deleted file mode 100644 index 44dc19e44f92..000000000000 --- a/.github/workflows/dependent-issues.yaml +++ /dev/null @@ -1,32 +0,0 @@ -# Part of the Carbon Language project, under the Apache License v2.0 with LLVM -# Exceptions. See /LICENSE for license information. -# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception - -name: Dependent Issues - -on: - issues: - types: - - opened - - edited - - reopened - pull_request_target: - types: - - opened - - edited - - reopened - - synchronize - schedule: - - cron: '0 0 * * *' # daily - -jobs: - check: - runs-on: ubuntu-latest - steps: - - uses: z0al/dependent-issues@v1 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - label: dependent - check_issues: on - keywords: depends on, blocked by diff --git a/.github/workflows/pre-commit.yaml b/.github/workflows/pre_commit.yaml similarity index 100% rename from .github/workflows/pre-commit.yaml rename to .github/workflows/pre_commit.yaml