Fix parse support for 'fn F[];' (#5135)

According to approved syntax at
https://github.com/carbon-language/carbon-lang/blob/trunk/proposals/p3848.md#syntax-defined,
`fn F[]` without explicit parameters should be valid. This makes it
work, then adds some validation to prevent `class C[]` in check.

Note that for `fn`, positional parameters are a TODO -- but this allows
me to test validation in `fn destroy[]` which is rejected, not just a
TODO.
This commit is contained in:
Jon Ross-Perkins
2025-03-18 00:31:17 +00:00
committed by GitHub
parent a584ee120e
commit 8738497301
15 changed files with 402 additions and 93 deletions
@@ -86,17 +86,13 @@ auto HandleDeclNameAndParams(Context& context) -> void {
auto HandleDeclNameAndParamsAfterImplicit(Context& context) -> void {
auto state = context.PopState();
state.state = State::DeclNameAndParamsAfterParams;
context.PushState(state);
if (!context.PositionIs(Lex::TokenKind::OpenParen)) {
CARBON_DIAGNOSTIC(
ParamsRequiredAfterImplicit, Error,
"a `(` for parameters is required after implicit parameters");
context.emitter().Emit(*context.position(), ParamsRequiredAfterImplicit);
context.ReturnErrorOnState();
return;
}
state.state = State::DeclNameAndParamsAfterParams;
context.PushState(state);
context.PushState(State::PatternListAsExplicit);
}