C++ Interop: Fix access calculation to handle private member of base classes correctly (#6238)

Browse Source

Always take into account both the lookup access specifier and the
declaration. When set, lookup access specifier takes precedence. When
not set, we have two use cases:
1. This is not a record member, so no access is specified at all. Treat
this as public.
2. This is a record member of a base class. Treat this as private.
[Reference](https://github.com/llvm/llvm-project/blob/4b1d7827c07381610ad4fa7bd9d1a9659008b963/clang/include/clang/AST/DeclCXX.h#L1724).

Also, deduplicate access mapping between import and overload resolution.

Background:
https://github.com/carbon-language/carbon-lang/pull/6221#issuecomment-3407981790

Part of #5859.

...

This commit is contained in:

Boaz Brickner

2025-10-21 08:12:57 +00:00

committed by GitHub

parent 3d6810beb6

commit 840562feb3

6 changed files with 1924 additions and 151 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

toolchain/check/testdata/interop/cpp/class/access.carbon

Vendored

+1843 -110

File diff suppressed because it is too large Load Diff