mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-16 00:28:12 +00:00
Refactor SemanticsNode factory functions into factory templates. (#2711)
I'm trying to reduce the amount of per-SemanticsNodeKind boilerplate, and make mistakes (e.g., SemanticsNodeKind not matching the Make name, misplacing the type, or Get/Make type mismatches) easier to see. I could've done this with (more) macros, but felt that the template approach was reasonable enough and likely easier to understand/debug. I'm not sure whether there's more that I could be doing with variadics to reduce the amount of factory code, but this feels good right now.
This commit is contained in:
1 parent
4fa11af13f
commit
7fc203c536
7 files changed
+201
-185
No files matched your search
@@ -31,8 +31,8 @@ void SemanticsNode::Print(llvm::raw_ostream& out) const {
|
||||
break;
|
||||
#include "toolchain/semantics/semantics_node_kind.def"
|
||||
}
|
||||
if (type_.is_valid()) {
|
||||
out << ", type: " << type_;
|
||||
if (type_id_.is_valid()) {
|
||||
out << ", type: " << type_id_;
|
||||
}
|
||||
out << "}";
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user