carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-09-24 22:02:23 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Refactor SemanticsNode factory functions into factory templates. (#2711)

Browse Source 
I'm trying to reduce the amount of per-SemanticsNodeKind boilerplate, and make mistakes (e.g., SemanticsNodeKind not matching the Make name, misplacing the type, or Get/Make type mismatches) easier to see.

I could've done this with (more) macros, but felt that the template approach was reasonable enough and likely easier to understand/debug. I'm not sure whether there's more that I could be doing with variadics to reduce the amount of factory code, but this feels good right now.
This commit is contained in:
Jon Ross-Perkins
2023-03-27 11:07:49 -07:00
committed by GitHub
parent 4fa11af13f
commit 7fc203c536
7 changed files with 201 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/semantics/semantics_node.cpp
+2 -2
View File
@@ -31,8 +31,8 @@ void SemanticsNode::Print(llvm::raw_ostream& out) const {
break;
#include "toolchain/semantics/semantics_node_kind.def"
}
if (type_.is_valid()) {
out << ", type: " << type_;
if (type_id_.is_valid()) {
out << ", type: " << type_id_;
}
out << "}";
}