carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Add diagnostic support to pass in NameId. (#3696)

Browse Source 
Builds on #3695 to provide equivalent support for NameId.
This commit is contained in:
Jon Ross-Perkins
2024-02-09 17:26:03 +00:00
committed by GitHub
parent 1bf4dc53d9
commit 7e7e87056a
10 changed files with 30 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/handle_function.cpp
+2 -3
View File
@@ -206,12 +206,11 @@ auto HandleFunctionDefinitionStart(Context& context,
// Track that this declaration is the definition.
if (function.definition_id.is_valid()) {
CARBON_DIAGNOSTIC(FunctionRedefinition, Error,
"Redefinition of function {0}.", std::string);
"Redefinition of function {0}.", SemIR::NameId);
CARBON_DIAGNOSTIC(FunctionPreviousDefinition, Note,
"Previous definition was here.");
context.emitter()
.Build(parse_node, FunctionRedefinition,
context.names().GetFormatted(function.name_id).str())
.Build(parse_node, FunctionRedefinition, function.name_id)
.Note(function.definition_id, FunctionPreviousDefinition)
.Emit();
} else {