carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-04 18:41:03 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Switch custom error stream output to diagnostic (#4846)

Browse Source 
This switches most error printing to use diagnostics instead of direct
stream writes, even when not a specific file diagnostic. I'm allowing
empty filenames for this use-case.

This allows a little more specific testing to validate coverage of
output using the diagnostic coverage test. I'm adding a few tests to
cover things that weren't previously tested.

Separately, this also forces a little more standardization in format...
considering how changes like #4568 show effort being spent to _mirror_
diagnostic style, my thought is now to just use diagnostic code where
possible.

Note this also allows incrementally better testing of the language
server; I'm changing the crash fix from #4847 in favor of diagnostic
testing.

---------

Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
This commit is contained in:
Jon Ross-Perkins
2025-01-30 01:58:07 +00:00
committed by GitHub
co-authored by Chandler Carruth
parent 7d2958ad37
commit 7befe2ce9f
57 changed files with 379 additions and 174 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/check/context.cpp
+1 -1
View File
@@ -223,7 +223,7 @@ auto Context::DiagnoseDuplicateName(SemIRLoc dup_def, SemIRLoc prev_def)
.Emit();
}
auto Context::DiagnosePoisonedName(SemIRLoc loc) -> void {
auto Context::DiagnosePoisonedName(SemIR::InstId loc) -> void {
// TODO: Improve the diagnostic to replace NodeId::None with the location
// where the name was poisoned. See discussion in
// https://github.com/carbon-language/carbon-lang/pull/4654#discussion_r1876607172