carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Basic support for impl virtual override keyword (#2493)

Browse Source 
Features:
* Add basic support for `impl` virtual methods (override virtual method)
* Error on invalid declaration for `impl` and `virtual`, covering simple use cases
* Add `abstract` fn parser-only support

Changes:
* Modify parser to handle new function specifiers, resolve conflicts
    * Group `virtual_override` and `FN`, and group `impl_kind` and `IMPL` to avoid ambiguities with around `impl` token parsing
* Add new `VirtualOverride` enum for function declarations, and matching `virt_override() -> VirtualOverride` getter
* Update function declaration logic

Depends on #2462
This commit is contained in:
Adrien Leravat
2023-01-04 11:09:23 -08:00
committed by GitHub
parent 8301258ef8
commit 798a40c886
16 changed files with 197 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/ast/ast_test_matchers_test.cpp
+3 -3
View File
@@ -103,7 +103,7 @@ TEST(MatchesFunctionDeclarationTest, BasicUsage) {
Block body(DummyLoc, {});
FunctionDeclaration decl(DummyLoc, "Foo", {}, std::nullopt, &params,
ReturnTerm::Omitted(DummyLoc), &body,
/*is_virtual=*/false);
VirtualOverride::None);
EXPECT_THAT(decl, MatchesFunctionDeclaration());
EXPECT_THAT(&decl, MatchesFunctionDeclaration());
@@ -117,7 +117,7 @@ TEST(MatchesFunctionDeclarationTest, BasicUsage) {
FunctionDeclaration forward_decl(DummyLoc, "Foo", {}, std::nullopt, &params,
ReturnTerm::Omitted(DummyLoc), std::nullopt,
/*is_virtual=*/false);
VirtualOverride::None);
EXPECT_THAT(forward_decl, MatchesFunctionDeclaration().WithName("Foo"));
EXPECT_THAT(forward_decl, Not(MatchesFunctionDeclaration().WithBody(_)));
@@ -151,7 +151,7 @@ TEST(ASTDeclarationsTest, BasicUsage) {
Block body(DummyLoc, {});
FunctionDeclaration decl(DummyLoc, "Foo", {}, std::nullopt, &params,
ReturnTerm::Omitted(DummyLoc), &body,
/*is_virtual=*/false);
VirtualOverride::None);
AST ast = {.declarations = {&decl}};
EXPECT_THAT(ast, ASTDeclarations(ElementsAre(MatchesFunctionDeclaration())));