From 795729bb4ab308baa2e7435dfa33be04416f0ace Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Tue, 22 Sep 2026 17:23:11 +0000 Subject: [PATCH] Fix git path globs in summarize testdata changes SKILL (#7818) When there's a wildcard in a path, git treats the path as matching exactly, unless the path also ends in a wildcard. So `toolchain/*/testdata` only matches the testdata directory names, whereas `toolchain/*/testdata/*` matches all the files under them. --- .agents/skills/summarize_testdata_changes/SKILL.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.agents/skills/summarize_testdata_changes/SKILL.md b/.agents/skills/summarize_testdata_changes/SKILL.md index 0053d88f5df8..20656df6e9f5 100644 --- a/.agents/skills/summarize_testdata_changes/SKILL.md +++ b/.agents/skills/summarize_testdata_changes/SKILL.md @@ -40,10 +40,11 @@ input changes. #### For Git Users: -- **Summarize code changes**: `git diff --stat -- ':!toolchain/*/testdata'` +- **Summarize code changes**: `git diff --stat -- ':!toolchain/*/testdata/*'` - To see content of non-testdata changes: - `git diff -- ':!toolchain/*/testdata'` -- **Identify testdata changes**: `git diff --name-only 'toolchain/*/testdata'` + `git diff -- ':!toolchain/*/testdata/*'` +- **Identify testdata changes**: + `git diff --name-only 'toolchain/*/testdata/*'` #### For Jujutsu (jj) Users: @@ -80,7 +81,7 @@ STDOUT changes. This script reads a unified diff from stdin. ```bash # For Git: -git diff -- 'toolchain/*/testdata' | python3 .agents/skills/summarize_testdata_changes/scripts/parse_diff.py +git diff -- 'toolchain/*/testdata/*' | python3 .agents/skills/summarize_testdata_changes/scripts/parse_diff.py # For Jujutsu (jj): jj diff --git 'toolchain/*/testdata' | python3 .agents/skills/summarize_testdata_changes/scripts/parse_diff.py