carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 15:51:07 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Explorer: fix case for CleanUpAction enum kind (#2520)

Browse Source 
Currently, only the action class uses the noun case (`Cleanup`), while the kind enum and functions are spelled `CleanUpAction`. Other actions use consistent casing between class and enum names. This change makes the name consistent, and unsurprising for developers. Mirrors `DestroyAction` (verb).
This commit is contained in:
Adrien Leravat
2023-01-10 19:22:50 -08:00
committed by GitHub
parent d70e237026
commit 7936bfa019
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
explorer/interpreter/action_stack.cpp
+3 -3
View File
@@ -238,7 +238,7 @@ auto ActionStack::UnwindToWithCaptureScopesToDestroy(
auto& scope = item->scope();
if (scope && item->kind() != Action::Kind::CleanUpAction) {
std::unique_ptr<Action> cleanup_action =
std::make_unique<CleanupAction>(std::move(*scope));
std::make_unique<CleanUpAction>(std::move(*scope));
scopes_to_destroy.push(std::move(cleanup_action));
}
}
@@ -332,7 +332,7 @@ void ActionStack::PushCleanUpActions(
auto& act = actions.top();
if (act->scope()) {
std::unique_ptr<Action> cleanup_action =
std::make_unique<CleanupAction>(std::move(*act->scope()));
std::make_unique<CleanUpAction>(std::move(*act->scope()));
todo_.Push(std::move(cleanup_action));
}
actions.pop();
@@ -343,7 +343,7 @@ void ActionStack::PushCleanUpAction(std::unique_ptr<Action> act) {
auto& scope = act->scope();
if (scope && act->kind() != Action::Kind::CleanUpAction) {
std::unique_ptr<Action> cleanup_action =
std::make_unique<CleanupAction>(std::move(*scope));
std::make_unique<CleanUpAction>(std::move(*scope));
todo_.Push(std::move(cleanup_action));
}
}