carbon-language/carbon-lang
1
0
Fork 0
mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-05 22:02:55 +01:00
Code Issues Packages Projects Releases 10 Wiki Activity

Remove return_slot_id (#4577)

Browse Source 
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
This commit is contained in:
Geoff Romer
2024-12-04 00:21:24 +00:00
committed by GitHub
co-authored by Richard Smith
parent 33110d096c
commit 78d7a7c291
109 changed files with 1160 additions and 1185 deletions
Download Patch File Download Diff File Expand all files Collapse all files
toolchain/lower/file_context.cpp
+4 -7
View File
@@ -230,10 +230,7 @@ auto FileContext::BuildFunctionDecl(SemIR::FunctionId function_id,
if (return_info.has_return_slot()) {
param_types.push_back(
llvm::PointerType::get(return_type, /*AddressSpace=*/0));
return_param_id = sem_ir()
.insts()
.GetAs<SemIR::ReturnSlot>(function.return_slot_id)
.storage_id;
return_param_id = function.return_slot_pattern_id;
param_inst_ids.push_back(return_param_id);
}
for (auto param_pattern_id : llvm::concat<const SemIR::InstId>(
@@ -352,11 +349,11 @@ auto FileContext::BuildFunctionDefinition(SemIR::FunctionId function_id)
// The subset of call_param_ids that is already in the order that the LLVM
// calling convention expects.
llvm::ArrayRef<SemIR::InstId> sequential_param_ids;
if (function.return_slot_id.is_valid()) {
if (function.return_slot_pattern_id.is_valid()) {
// The LLVM calling convention has the return slot first rather than last.
// Note that this queries whether there is a return slot at the LLVM level,
// whereas `function.return_slot_id.is_valid()` queries whether there is a
// return slot at the SemIR level.
// whereas `function.return_slot_pattern_id.is_valid()` queries whether
// there is a return slot at the SemIR level.
if (SemIR::ReturnTypeInfo::ForFunction(sem_ir(), function, specific_id)
.has_return_slot()) {
lower_param(call_param_ids.back());