From 785ab04ede76325992b5d6a63d472e8240daede7 Mon Sep 17 00:00:00 2001 From: Jon Ross-Perkins Date: Wed, 17 Jan 2024 11:52:29 -0800 Subject: [PATCH] Address a likely issue with language_server (#3610) The `node_kind` check is on `ch`, so the `node_token` probably should be too. Trying to address the issue reported by [skoriop on Discord](https://discord.com/channels/655572317891461132/993958660277555301/1197201736226574420) Note, I haven't tested this beyond building. --- language_server/language_server.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/language_server/language_server.cpp b/language_server/language_server.cpp index c8be5740b1a4..a025f59c6a2a 100644 --- a/language_server/language_server.cpp +++ b/language_server/language_server.cpp @@ -84,7 +84,7 @@ static auto GetIdentifierName(const SharedValueStores& value_stores, for (auto ch : p.children(node)) { if (p.node_kind(ch) == Parse::NodeKind::IdentifierName) { return value_stores.identifiers().Get( - tokens.GetIdentifier(p.node_token(node))); + tokens.GetIdentifier(p.node_token(ch))); } } return std::nullopt;