diff --git a/toolchain/check/BUILD b/toolchain/check/BUILD index aae82a2a81b2..aed93aaf5776 100644 --- a/toolchain/check/BUILD +++ b/toolchain/check/BUILD @@ -46,7 +46,7 @@ cc_library( "context.h", "convert.h", "declaration_name_stack.h", - "node_block_stack.h", + "inst_block_stack.h", "pending_block.h", ], deps = [ diff --git a/toolchain/check/context.cpp b/toolchain/check/context.cpp index f757c4d1dcd8..3e74c77672a0 100644 --- a/toolchain/check/context.cpp +++ b/toolchain/check/context.cpp @@ -11,12 +11,12 @@ #include "common/vlog.h" #include "llvm/ADT/Sequence.h" #include "toolchain/check/declaration_name_stack.h" -#include "toolchain/check/node_block_stack.h" +#include "toolchain/check/inst_block_stack.h" #include "toolchain/lex/tokenized_buffer.h" #include "toolchain/parse/node_kind.h" #include "toolchain/sem_ir/file.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::Check { diff --git a/toolchain/check/context.h b/toolchain/check/context.h index 9f130ac492af..301fa139baee 100644 --- a/toolchain/check/context.h +++ b/toolchain/check/context.h @@ -10,7 +10,7 @@ #include "llvm/ADT/FoldingSet.h" #include "llvm/ADT/SmallVector.h" #include "toolchain/check/declaration_name_stack.h" -#include "toolchain/check/node_block_stack.h" +#include "toolchain/check/inst_block_stack.h" #include "toolchain/check/node_stack.h" #include "toolchain/parse/tree.h" #include "toolchain/sem_ir/file.h" diff --git a/toolchain/check/convert.cpp b/toolchain/check/convert.cpp index fb885e39ade1..e82318d5cc31 100644 --- a/toolchain/check/convert.cpp +++ b/toolchain/check/convert.cpp @@ -14,7 +14,7 @@ #include "toolchain/parse/node_kind.h" #include "toolchain/sem_ir/file.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::Check { diff --git a/toolchain/check/handle_array.cpp b/toolchain/check/handle_array.cpp index b5f4634eae4a..e01fc0c9f6d6 100644 --- a/toolchain/check/handle_array.cpp +++ b/toolchain/check/handle_array.cpp @@ -6,7 +6,7 @@ #include "toolchain/check/convert.h" #include "toolchain/parse/node_kind.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::Check { diff --git a/toolchain/check/handle_index.cpp b/toolchain/check/handle_index.cpp index 936f78382824..2d3306ef5ebe 100644 --- a/toolchain/check/handle_index.cpp +++ b/toolchain/check/handle_index.cpp @@ -6,7 +6,7 @@ #include "toolchain/check/context.h" #include "toolchain/check/convert.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::Check { diff --git a/toolchain/check/inst_block_stack.cpp b/toolchain/check/inst_block_stack.cpp index f53c4470bebc..1c8cd37d1397 100644 --- a/toolchain/check/inst_block_stack.cpp +++ b/toolchain/check/inst_block_stack.cpp @@ -2,10 +2,11 @@ // Exceptions. See /LICENSE for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +#include "toolchain/check/inst_block_stack.h" + #include "common/vlog.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/StringExtras.h" -#include "toolchain/check/node_block_stack.h" #include "toolchain/sem_ir/inst.h" namespace Carbon::Check { diff --git a/toolchain/check/node_block_stack.h b/toolchain/check/inst_block_stack.h similarity index 96% rename from toolchain/check/node_block_stack.h rename to toolchain/check/inst_block_stack.h index 0e9e458d7e27..2cdeb152349d 100644 --- a/toolchain/check/node_block_stack.h +++ b/toolchain/check/inst_block_stack.h @@ -2,8 +2,8 @@ // Exceptions. See /LICENSE for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception -#ifndef CARBON_TOOLCHAIN_CHECK_NODE_BLOCK_STACK_H_ -#define CARBON_TOOLCHAIN_CHECK_NODE_BLOCK_STACK_H_ +#ifndef CARBON_TOOLCHAIN_CHECK_INST_BLOCK_STACK_H_ +#define CARBON_TOOLCHAIN_CHECK_INST_BLOCK_STACK_H_ #include "llvm/ADT/SmallVector.h" #include "toolchain/sem_ir/file.h" @@ -119,4 +119,4 @@ class InstBlockStack { } // namespace Carbon::Check -#endif // CARBON_TOOLCHAIN_CHECK_NODE_BLOCK_STACK_H_ +#endif // CARBON_TOOLCHAIN_CHECK_INST_BLOCK_STACK_H_ diff --git a/toolchain/check/testdata/basics/builtin_nodes.carbon b/toolchain/check/testdata/basics/builtin_insts.carbon similarity index 96% rename from toolchain/check/testdata/basics/builtin_nodes.carbon rename to toolchain/check/testdata/basics/builtin_insts.carbon index d832e99ad4ad..019094a2f0cb 100644 --- a/toolchain/check/testdata/basics/builtin_nodes.carbon +++ b/toolchain/check/testdata/basics/builtin_insts.carbon @@ -7,7 +7,7 @@ // AUTOUPDATE // CHECK:STDOUT: --- -// CHECK:STDOUT: filename: builtin_nodes.carbon +// CHECK:STDOUT: filename: builtin_insts.carbon // CHECK:STDOUT: sem_ir: // CHECK:STDOUT: cross_reference_irs_size: 1 // CHECK:STDOUT: functions: {} diff --git a/toolchain/lower/file_context.cpp b/toolchain/lower/file_context.cpp index 65d02f103154..36a44aa8597e 100644 --- a/toolchain/lower/file_context.cpp +++ b/toolchain/lower/file_context.cpp @@ -11,7 +11,7 @@ #include "toolchain/sem_ir/entry_point.h" #include "toolchain/sem_ir/file.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::Lower { diff --git a/toolchain/lower/function_context.cpp b/toolchain/lower/function_context.cpp index 7ef8f03960ed..52b62b5d9b03 100644 --- a/toolchain/lower/function_context.cpp +++ b/toolchain/lower/function_context.cpp @@ -48,7 +48,7 @@ auto FunctionContext::LowerBlock(SemIR::InstBlockId block_id) -> void { case SemIR::Name::Kind: \ Handle##Name(*this, inst_id, inst.As()); \ break; -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" } } } diff --git a/toolchain/lower/function_context.h b/toolchain/lower/function_context.h index 9924dc2028d9..bec980c52df6 100644 --- a/toolchain/lower/function_context.h +++ b/toolchain/lower/function_context.h @@ -138,7 +138,7 @@ class FunctionContext { auto Handle##Name(FunctionContext& context, SemIR::InstId inst_id, \ SemIR::Name inst) \ ->void; -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" } // namespace Carbon::Lower diff --git a/toolchain/lower/handle.cpp b/toolchain/lower/handle.cpp index 72c8b63dad18..3bea437966ce 100644 --- a/toolchain/lower/handle.cpp +++ b/toolchain/lower/handle.cpp @@ -6,7 +6,7 @@ #include "llvm/ADT/Sequence.h" #include "toolchain/lower/function_context.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::Lower { diff --git a/toolchain/sem_ir/BUILD b/toolchain/sem_ir/BUILD index a7ca6af5fec3..2a499ce1d5cb 100644 --- a/toolchain/sem_ir/BUILD +++ b/toolchain/sem_ir/BUILD @@ -27,12 +27,12 @@ cc_library( cc_library( name = "inst_kind", - srcs = ["node_kind.cpp"], + srcs = ["inst_kind.cpp"], hdrs = [ - "node_kind.h", + "inst_kind.h", "typed_insts.h", ], - textual_hdrs = ["node_kind.def"], + textual_hdrs = ["inst_kind.def"], deps = [ "//common:enum_base", "//toolchain/parse:tree", @@ -112,7 +112,7 @@ cc_library( cc_test( name = "typed_insts_test", size = "small", - srcs = ["typed_nodes_test.cpp"], + srcs = ["typed_insts_test.cpp"], deps = [ ":inst", ":inst_kind", diff --git a/toolchain/sem_ir/file.cpp b/toolchain/sem_ir/file.cpp index 64a1f8324527..d6804475bff2 100644 --- a/toolchain/sem_ir/file.cpp +++ b/toolchain/sem_ir/file.cpp @@ -11,7 +11,7 @@ #include "toolchain/base/yaml.h" #include "toolchain/sem_ir/builtin_kind.h" #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" namespace Carbon::SemIR { diff --git a/toolchain/sem_ir/formatter.cpp b/toolchain/sem_ir/formatter.cpp index 57371e5c2100..cb9b6496eacf 100644 --- a/toolchain/sem_ir/formatter.cpp +++ b/toolchain/sem_ir/formatter.cpp @@ -630,7 +630,7 @@ class Formatter { case InstT::Kind: \ FormatInstruction(inst_id, inst.As()); \ break; -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" } } diff --git a/toolchain/sem_ir/inst.cpp b/toolchain/sem_ir/inst.cpp index 11ec5864b705..45cd0db55041 100644 --- a/toolchain/sem_ir/inst.cpp +++ b/toolchain/sem_ir/inst.cpp @@ -26,7 +26,7 @@ auto Inst::Print(llvm::raw_ostream& out) const -> void { case Name::Kind: \ print_args(TypedInstArgsInfo()); \ break; -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" } if (type_id_.is_valid()) { out << ", type: " << type_id_; diff --git a/toolchain/sem_ir/inst.h b/toolchain/sem_ir/inst.h index 3873d47d8aa0..282d52b905b0 100644 --- a/toolchain/sem_ir/inst.h +++ b/toolchain/sem_ir/inst.h @@ -13,7 +13,7 @@ #include "toolchain/base/index_base.h" #include "toolchain/parse/tree.h" #include "toolchain/sem_ir/builtin_kind.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" #include "toolchain/sem_ir/typed_insts.h" namespace Carbon::SemIR { diff --git a/toolchain/sem_ir/node_kind.cpp b/toolchain/sem_ir/inst_kind.cpp similarity index 86% rename from toolchain/sem_ir/node_kind.cpp rename to toolchain/sem_ir/inst_kind.cpp index 5f531baa7901..8cd8b774c056 100644 --- a/toolchain/sem_ir/node_kind.cpp +++ b/toolchain/sem_ir/inst_kind.cpp @@ -2,7 +2,7 @@ // Exceptions. See /LICENSE for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" #include "toolchain/sem_ir/typed_insts.h" @@ -10,7 +10,7 @@ namespace Carbon::SemIR { CARBON_DEFINE_ENUM_CLASS_NAMES(InstKind) = { #define CARBON_SEM_IR_INST_KIND(Name) CARBON_ENUM_CLASS_NAME_STRING(Name) -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" }; auto InstKind::ir_name() const -> llvm::StringLiteral { @@ -21,7 +21,7 @@ auto InstKind::value_kind() const -> InstValueKind { static constexpr InstValueKind Table[] = { #define CARBON_SEM_IR_INST_KIND(Name) \ HasTypeId ? InstValueKind::Typed : InstValueKind::None, -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" }; return Table[AsInt()]; } @@ -33,7 +33,7 @@ auto InstKind::terminator_kind() const -> TerminatorKind { auto InstKind::definition() const -> const Definition& { static constexpr const Definition* Table[] = { #define CARBON_SEM_IR_INST_KIND(Name) &SemIR::Name::Kind, -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" }; return *Table[AsInt()]; } diff --git a/toolchain/sem_ir/node_kind.def b/toolchain/sem_ir/inst_kind.def similarity index 100% rename from toolchain/sem_ir/node_kind.def rename to toolchain/sem_ir/inst_kind.def diff --git a/toolchain/sem_ir/node_kind.h b/toolchain/sem_ir/inst_kind.h similarity index 94% rename from toolchain/sem_ir/node_kind.h rename to toolchain/sem_ir/inst_kind.h index 7af5f0aec2c3..5b21a131523b 100644 --- a/toolchain/sem_ir/node_kind.h +++ b/toolchain/sem_ir/inst_kind.h @@ -2,8 +2,8 @@ // Exceptions. See /LICENSE for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception -#ifndef CARBON_TOOLCHAIN_SEM_IR_NODE_KIND_H_ -#define CARBON_TOOLCHAIN_SEM_IR_NODE_KIND_H_ +#ifndef CARBON_TOOLCHAIN_SEM_IR_INST_KIND_H_ +#define CARBON_TOOLCHAIN_SEM_IR_INST_KIND_H_ #include @@ -40,13 +40,13 @@ enum class TerminatorKind : int8_t { CARBON_DEFINE_RAW_ENUM_CLASS(InstKind, uint8_t) { #define CARBON_SEM_IR_INST_KIND(Name) CARBON_RAW_ENUM_ENUMERATOR(Name) -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" }; class InstKind : public CARBON_ENUM_BASE(InstKind) { public: #define CARBON_SEM_IR_INST_KIND(Name) CARBON_ENUM_CONSTANT_DECLARATION(Name) -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" using EnumBase::Create; @@ -82,7 +82,7 @@ class InstKind : public CARBON_ENUM_BASE(InstKind) { #define CARBON_SEM_IR_INST_KIND(Name) \ CARBON_ENUM_CONSTANT_DEFINITION(InstKind, Name) -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" // We expect the instruction kind to fit compactly into 8 bits. static_assert(sizeof(InstKind) == 1, "Kind objects include padding!"); @@ -128,4 +128,4 @@ constexpr auto InstKind::Define(llvm::StringLiteral ir_name, } // namespace Carbon::SemIR -#endif // CARBON_TOOLCHAIN_SEM_IR_NODE_KIND_H_ +#endif // CARBON_TOOLCHAIN_SEM_IR_INST_KIND_H_ diff --git a/toolchain/sem_ir/typed_insts.h b/toolchain/sem_ir/typed_insts.h index 1ff56eaa1c5a..165b72aa53c9 100644 --- a/toolchain/sem_ir/typed_insts.h +++ b/toolchain/sem_ir/typed_insts.h @@ -8,7 +8,7 @@ #include "toolchain/parse/tree.h" #include "toolchain/sem_ir/builtin_kind.h" #include "toolchain/sem_ir/ids.h" -#include "toolchain/sem_ir/node_kind.h" +#include "toolchain/sem_ir/inst_kind.h" // Representations for specific kinds of instructions. // diff --git a/toolchain/sem_ir/typed_nodes_test.cpp b/toolchain/sem_ir/typed_insts_test.cpp similarity index 98% rename from toolchain/sem_ir/typed_nodes_test.cpp rename to toolchain/sem_ir/typed_insts_test.cpp index 7f098915368b..12eede3ef748 100644 --- a/toolchain/sem_ir/typed_nodes_test.cpp +++ b/toolchain/sem_ir/typed_insts_test.cpp @@ -2,11 +2,12 @@ // Exceptions. See /LICENSE for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +#include "toolchain/sem_ir/typed_insts.h" + #include #include #include "toolchain/sem_ir/inst.h" -#include "toolchain/sem_ir/typed_insts.h" namespace Carbon::SemIR { @@ -28,7 +29,7 @@ namespace { // InstKind enumerator. #define CARBON_SEM_IR_INST_KIND(Name) \ static_assert(Name::Kind == InstKind::Name); -#include "toolchain/sem_ir/node_kind.def" +#include "toolchain/sem_ir/inst_kind.def" template using TypesExceptFirst = ::testing::Types; @@ -38,7 +39,7 @@ using TypesExceptFirst = ::testing::Types; // list. using TypedInstTypes = TypesExceptFirst; // Set up the test fixture.