mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 14:51:03 +01:00
Refactor testing exe path and benchmark main handling. (#4216)
Consolidates both main libraries into `//testing/base`, and factors out the exe path handling for benchmarks and unit tests into a common library to remove duplication. Refactors how that logic is managed to be cleaner and avoid a confusing bool that came up in code review. Updates all the tests and benchmarks that use these. I still need to update other benchmarks to use the same main, but I wanted to keep this PR somewhat minimal. This also fixes a bug noticed in passing that the compilation benchmark didn't have the required dependency on the benchmark library itself, just the benchmark main library.
This commit is contained in:
@@ -8,7 +8,7 @@
|
||||
#include <gtest/gtest.h>
|
||||
|
||||
#include "common/set.h"
|
||||
#include "testing/base/gtest_main.h"
|
||||
#include "testing/base/global_exe_path.h"
|
||||
#include "toolchain/driver/driver.h"
|
||||
|
||||
namespace Carbon::Testing {
|
||||
@@ -144,7 +144,7 @@ TEST(SourceGenTest, UniqueIdentifiers) {
|
||||
auto TestCompile(llvm::StringRef source) -> bool {
|
||||
llvm::vfs::InMemoryFileSystem fs;
|
||||
InstallPaths installation(
|
||||
InstallPaths::MakeForBazelRunfiles(Testing::GetTestExePath()));
|
||||
InstallPaths::MakeForBazelRunfiles(Testing::GetExePath()));
|
||||
Driver driver(fs, &installation, llvm::outs(), llvm::errs());
|
||||
|
||||
// Load the prelude into our VFS.
|
||||
|
||||
Reference in New Issue
Block a user