mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-18 02:30:29 +00:00
For-range in replacement logic (#631)
This replaces GetAstMatcher with AddMatcher because cxxForRangeStmt is a StatementMatcher. addMatcher has multiple definitions (https://clang.llvm.org/doxygen/classclang_1_1ast__matchers_1_1MatchFinder.html) and so this approach allows using the right addMatcher without writing per-call overloads. To handle the `var`, I'm considering something like moving VarDecl logic into a VarMatcherBase so that I can just use CXXForRangeStmt's getLoopVariable. The problem is a for-range statement has multiple VarDecls, and getLoopVariable may be the easiest way to identify the real one.
This commit is contained in:
1 parent
c4079bfdae
commit
6fa42a7f3c
18 files changed
+212
-69
No files matched your search
@@ -5,6 +5,7 @@
|
||||
#include "clang/Tooling/CommonOptionsParser.h"
|
||||
#include "clang/Tooling/Refactoring.h"
|
||||
#include "migrate_cpp/cpp_refactoring/fn_inserter.h"
|
||||
#include "migrate_cpp/cpp_refactoring/for_range.h"
|
||||
#include "migrate_cpp/cpp_refactoring/matcher_manager.h"
|
||||
#include "migrate_cpp/cpp_refactoring/var_decl.h"
|
||||
|
||||
@@ -35,6 +36,7 @@ auto main(int argc, const char** argv) -> int {
|
||||
// Set up AST matcher callbacks.
|
||||
Carbon::MatcherManager matchers(&tool.getReplacements());
|
||||
matchers.Register(std::make_unique<Carbon::FnInserterFactory>());
|
||||
matchers.Register(std::make_unique<Carbon::ForRangeFactory>());
|
||||
matchers.Register(std::make_unique<Carbon::VarDeclFactory>());
|
||||
|
||||
return tool.runAndSave(
|
||||
|
||||
Reference in new issue
Block a user